From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ido Schimmel Subject: Re: [patch net 1/2] mlxsw: spectrum: Fix refcount bug on span entries Date: Fri, 11 Nov 2016 14:49:28 +0200 Message-ID: <20161111124928.dbxqswx6akatsjrt@splinter> References: <1478859642-2918-1-git-send-email-jiri@resnulli.us> <1478859642-2918-2-git-send-email-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, yotamg@mellanox.com, arkadis@mellanox.com, idosch@mellanox.com, eladr@mellanox.com, nogahf@mellanox.com, ogerlitz@mellanox.com To: Jiri Pirko Return-path: Received: from out4-smtp.messagingengine.com ([66.111.4.28]:34002 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754581AbcKKMtc (ORCPT ); Fri, 11 Nov 2016 07:49:32 -0500 Content-Disposition: inline In-Reply-To: <1478859642-2918-2-git-send-email-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Nov 11, 2016 at 11:20:41AM +0100, Jiri Pirko wrote: > From: Yotam Gigi > > When binding port to a newly created span entry, its refcount is set 0 > even though it has a bound port. That leeds to unexpected behaviour when s/leeds/leads/ > the user tries to delete that port from the span entry. > > Change the binding process to increase the refcount of the bound entry > even if the entry is newly created, and add warning on the process of > removing bound port from entry when its refcount is 0. > > Fixes: 763b4b70afcd3 ("mlxsw: spectrum: Add support in matchall mirror TC offloading") You only need the first 12 characters. > Signed-off-by: Yotam Gigi > Signed-off-by: Jiri Pirko > --- > drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c > index 1ec0a4c..d75c1ff 100644 > --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c > +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c > @@ -269,17 +269,18 @@ static struct mlxsw_sp_span_entry > struct mlxsw_sp_span_entry *span_entry; > > span_entry = mlxsw_sp_span_entry_find(port); > - if (span_entry) { > - span_entry->ref_count++; > - return span_entry; > - } > + if (!span_entry) > + span_entry = mlxsw_sp_span_entry_create(port); > > - return mlxsw_sp_span_entry_create(port); > + span_entry->ref_count++; mlxsw_sp_span_entry_create() can return NULL. You can look at mlxsw_sp_fib_entry_get() for reference. > + return span_entry; > } > > static int mlxsw_sp_span_entry_put(struct mlxsw_sp *mlxsw_sp, > struct mlxsw_sp_span_entry *span_entry) > { > + WARN_ON(!span_entry->ref_count); > + > if (--span_entry->ref_count == 0) > mlxsw_sp_span_entry_destroy(mlxsw_sp, span_entry); > return 0; > -- > 2.7.4 >