From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: yibyang@cisco.com, tom@herbertland.com, jojvargh@cisco.com,
alexander.h.duyck@intel.com, ast@kernel.org, willemb@google.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net] net: __skb_flow_dissect() must cap its return value
Date: Sat, 12 Nov 2016 23:42:32 -0500 (EST) [thread overview]
Message-ID: <20161112.234232.1152946645540246281.davem@davemloft.net> (raw)
In-Reply-To: <1478736286.16809.17.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 09 Nov 2016 16:04:46 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> After Tom patch, thoff field could point past the end of the buffer,
> this could fool some callers.
>
> If an skb was provided, skb->len should be the upper limit.
> If not, hlen is supposed to be the upper limit.
>
> Fixes: a6e544b0a88b ("flow_dissector: Jump to exit code in __skb_flow_dissect")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Yibin Yang <yibyang@cisco.com
> Acked-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Acked-by: Willem de Bruijn <willemb@google.com>
> Acked-by: Alexei Starovoitov <ast@kernel.org>
Applied and queued up for -stable, thanks Eric.
prev parent reply other threads:[~2016-11-13 4:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1477438271.7065.157.camel@edumazet-glaptop3.roam.corp.google.com>
[not found] ` <1478718427.16809.7.camel@edumazet-glaptop3.roam.corp.google.com>
2016-11-10 0:04 ` [PATCH net] net: __skb_flow_dissect() must cap its return value Eric Dumazet
2016-11-13 4:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161112.234232.1152946645540246281.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=ast@kernel.org \
--cc=eric.dumazet@gmail.com \
--cc=jojvargh@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
--cc=willemb@google.com \
--cc=yibyang@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox