From: David Miller <davem@davemloft.net>
To: bjorn@mork.no
Cc: plz@plz.fi, netdev@vger.kernel.org
Subject: Re: [PATCH] Fixup packets with incorrect ethertype sent by ZTE MF821D
Date: Sun, 13 Nov 2016 12:00:15 -0500 (EST) [thread overview]
Message-ID: <20161113.120015.578328097660988615.davem@davemloft.net> (raw)
In-Reply-To: <87zil3cq9i.fsf@miraculix.mork.no>
From: Bjørn Mork <bjorn@mork.no>
Date: Sun, 13 Nov 2016 17:12:57 +0100
> In any case, if we're going to add a fix like this, then I want it way
> more generic. The only valid ethertypes expected from the modem is IP,
> IPV6 or ARP. Testing against those three, resetting anything else to IP,
> will at least catch *any* bogus value.
>
> But I'm not convinced I want this additional processing of every packet
> just to let Qualcomm go on hiring monkeys-on-crack to write their
> firmware. At least not when we do have raw-ip as a workaround for the
> issue.
>
> Feel free to try to convince me, though.
There are also several coding style problems with this patch.
next prev parent reply other threads:[~2016-11-13 17:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-13 13:47 [PATCH] Fixup packets with incorrect ethertype sent by ZTE MF821D Jussi Peltola
2016-11-13 16:12 ` Bjørn Mork
2016-11-13 17:00 ` David Miller [this message]
2016-11-13 17:25 ` Jussi Peltola
2016-11-14 0:22 ` Jussi Peltola
2016-11-14 11:37 ` Bjørn Mork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161113.120015.578328097660988615.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bjorn@mork.no \
--cc=netdev@vger.kernel.org \
--cc=plz@plz.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox