From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: vdronov@redhat.com, netdev@vger.kernel.org, marco.gra@gmail.com
Subject: Re: [PATCH v2 net] tcp: take care of truncations done by sk_filter()
Date: Sun, 13 Nov 2016 12:30:27 -0500 (EST) [thread overview]
Message-ID: <20161113.123027.772928399734865701.davem@davemloft.net> (raw)
In-Reply-To: <1478812355.8455.39.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 10 Nov 2016 13:12:35 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> With syzkaller help, Marco Grassi found a bug in TCP stack,
> crashing in tcp_collapse()
>
> Root cause is that sk_filter() can truncate the incoming skb,
> but TCP stack was not really expecting this to happen.
> It probably was expecting a simple DROP or ACCEPT behavior.
>
> We first need to make sure no part of TCP header could be removed.
> Then we need to adjust TCP_SKB_CB(skb)->end_seq
>
> Many thanks to syzkaller team and Marco for giving us a reproducer.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Marco Grassi <marco.gra@gmail.com>
> Reported-by: Vladis Dronov <vdronov@redhat.com>
> ---
> v2: reload both th/iph in case skb->head changed.
Applied and queued up for -stable, thanks Eric.
next prev parent reply other threads:[~2016-11-13 17:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1348037656.11947320.1478787081068.JavaMail.zimbra@redhat.com>
2016-11-10 14:47 ` BUG() can be hit in tcp_collapse() Vladis Dronov
2016-11-10 15:34 ` Greg KH
2016-11-10 15:44 ` Eric Dumazet
2016-11-10 19:26 ` Eric Dumazet
2016-11-10 19:49 ` Eric Dumazet
2016-11-10 20:13 ` Eric Dumazet
2016-11-10 20:50 ` [PATCH net] tcp: take care of truncations done by sk_filter() Eric Dumazet
2016-11-10 21:04 ` Eric Dumazet
2016-11-10 21:12 ` [PATCH v2 " Eric Dumazet
2016-11-13 17:30 ` David Miller [this message]
2016-11-11 13:08 ` BUG() can be hit in tcp_collapse() Vladis Dronov
2016-11-30 17:00 ` Vladis Dronov
2016-11-30 17:33 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161113.123027.772928399734865701.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=marco.gra@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vdronov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).