* [PATCH net 1/2] ibmvnic: Unmap ibmvnic_statistics structure
@ 2016-11-11 17:00 Thomas Falcon
2016-11-11 17:00 ` [PATCH net 2/2] ibmvnic: Fix size of debugfs name buffer Thomas Falcon
2016-11-13 18:42 ` [PATCH net 1/2] ibmvnic: Unmap ibmvnic_statistics structure David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Falcon @ 2016-11-11 17:00 UTC (permalink / raw)
To: netdev; +Cc: mwb
This structure was mapped but never subsequently unmapped.
Signed-off-by: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
---
drivers/net/ethernet/ibm/ibmvnic.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index f6c9b6d..921c40f 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -3844,6 +3844,9 @@ static int ibmvnic_remove(struct vio_dev *dev)
if (adapter->debugfs_dir && !IS_ERR(adapter->debugfs_dir))
debugfs_remove_recursive(adapter->debugfs_dir);
+ dma_unmap_single(&dev->dev, adapter->stats_token,
+ sizeof(struct ibmvnic_statistics), DMA_FROM_DEVICE);
+
if (adapter->ras_comps)
dma_free_coherent(&dev->dev,
adapter->ras_comp_num *
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH net 2/2] ibmvnic: Fix size of debugfs name buffer
2016-11-11 17:00 [PATCH net 1/2] ibmvnic: Unmap ibmvnic_statistics structure Thomas Falcon
@ 2016-11-11 17:00 ` Thomas Falcon
2016-11-13 18:42 ` David Miller
2016-11-13 18:42 ` [PATCH net 1/2] ibmvnic: Unmap ibmvnic_statistics structure David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Falcon @ 2016-11-11 17:00 UTC (permalink / raw)
To: netdev; +Cc: mwb
This mistake was causing debugfs directory creation
failures when multiple ibmvnic devices were probed.
Signed-off-by: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
---
drivers/net/ethernet/ibm/ibmvnic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 921c40f..4f3281a 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -3705,7 +3705,7 @@ static int ibmvnic_probe(struct vio_dev *dev, const struct vio_device_id *id)
struct net_device *netdev;
unsigned char *mac_addr_p;
struct dentry *ent;
- char buf[16]; /* debugfs name buf */
+ char buf[17]; /* debugfs name buf */
int rc;
dev_dbg(&dev->dev, "entering ibmvnic_probe for UA 0x%x\n",
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net 1/2] ibmvnic: Unmap ibmvnic_statistics structure
2016-11-11 17:00 [PATCH net 1/2] ibmvnic: Unmap ibmvnic_statistics structure Thomas Falcon
2016-11-11 17:00 ` [PATCH net 2/2] ibmvnic: Fix size of debugfs name buffer Thomas Falcon
@ 2016-11-13 18:42 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2016-11-13 18:42 UTC (permalink / raw)
To: tlfalcon; +Cc: netdev, mwb
From: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Date: Fri, 11 Nov 2016 11:00:45 -0600
> This structure was mapped but never subsequently unmapped.
>
> Signed-off-by: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-13 18:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-11 17:00 [PATCH net 1/2] ibmvnic: Unmap ibmvnic_statistics structure Thomas Falcon
2016-11-11 17:00 ` [PATCH net 2/2] ibmvnic: Fix size of debugfs name buffer Thomas Falcon
2016-11-13 18:42 ` David Miller
2016-11-13 18:42 ` [PATCH net 1/2] ibmvnic: Unmap ibmvnic_statistics structure David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).