From: Baoquan He <bhe@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, michael.chan@broadcom.com,
linux-kernel@vger.kernel.org, Dept-GELinuxNICDev@cavium.com,
rasesh.mody@cavium.com, harish.patil@cavium.com,
frank@undermydesk.org, jsr@dex.edzone.net, pmenzel@molgen.mpg.de,
jroedel@suse.de, dyoung@redhat.com
Subject: Re: [PATCH v2 2/2] bnx2: Wait for in-flight DMA to complete at probe stage
Date: Sun, 13 Nov 2016 12:54:29 +0800 [thread overview]
Message-ID: <20161113045429.GG15325@x1> (raw)
In-Reply-To: <20161112.234039.1001224346500132925.davem@davemloft.net>
On 11/12/16 at 11:40pm, David Miller wrote:
> From: Baoquan He <bhe@redhat.com>
> Date: Sun, 13 Nov 2016 12:15:24 +0800
>
> > In-flight DMA from 1st kernel could continue going in kdump kernel.
> > New io-page table has been created before bnx2 does reset at open stage.
> > We have to wait for the in-flight DMA to complete to avoid it look up
> > into the newly created io-page table at probe stage.
> >
> > Suggested-by: Michael Chan <michael.chan@broadcom.com>
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> > ---
> > v1->v2:
> > Michael suggested to wait for the in-flight DMA to complete at probe
> > stage. So give up the old method of trying to reset chip at probe
> > stage, take the new way accordingly.
>
> Patch updates don't work this way.
>
> When you update a patch that is part of a patch series, you must
> resubmit the entire series anew.
Thanks for telling, David!
Learned it. I am not very sure if this is what Michael is suggesting.
Will resubmit the entire patch series.
Thanks
Baoquan
next prev parent reply other threads:[~2016-11-13 4:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 13:46 [PATCH 0/2] bnx2: Hard reset bnx2 chip at probe stage Baoquan He
2016-11-11 13:46 ` [PATCH 1/2] Revert "bnx2: Reset device during driver initialization" Baoquan He
2016-11-11 13:51 ` Paul Menzel
2016-11-11 13:46 ` [PATCH 2/2] bnx2: Hard reset bnx2 chip at probe stage Baoquan He
2016-11-13 4:15 ` [PATCH v2 2/2] bnx2: Wait for in-flight DMA to complete " Baoquan He
2016-11-13 4:40 ` David Miller
2016-11-13 4:54 ` Baoquan He [this message]
2016-11-11 14:02 ` [PATCH 0/2] bnx2: Hard reset bnx2 chip " Baoquan He
2016-11-11 17:37 ` Michael Chan
2016-11-13 4:10 ` Baoquan He
-- strict thread matches above, loose matches on Subject: below --
2016-11-13 5:01 [PATCH v2 0/2] bnx2: Wait for in-flight DMA to complete " Baoquan He
2016-11-13 5:01 ` [PATCH v2 2/2] " Baoquan He
2016-11-13 19:02 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161113045429.GG15325@x1 \
--to=bhe@redhat.com \
--cc=Dept-GELinuxNICDev@cavium.com \
--cc=davem@davemloft.net \
--cc=dyoung@redhat.com \
--cc=frank@undermydesk.org \
--cc=harish.patil@cavium.com \
--cc=jroedel@suse.de \
--cc=jsr@dex.edzone.net \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=rasesh.mody@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).