From: Stephen Hemminger <stephen@networkplumber.org>
To: Roman Mashak <mrv@mojatatu.com>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com
Subject: Re: [PATCH iproute2 1/1] tc: print raw qdisc handle.
Date: Sun, 13 Nov 2016 09:53:37 +0300 [thread overview]
Message-ID: <20161113095337.1ac19e42@samsung9> (raw)
In-Reply-To: <1478790392-13028-1-git-send-email-mrv@mojatatu.com>
On Thu, 10 Nov 2016 10:06:32 -0500
Roman Mashak <mrv@mojatatu.com> wrote:
> Resending patch after fixing indentation and spaces.
>
> Signed-off-by: Roman Mashak <mrv@mojatatu.com>
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
iproute2 uses kernel coding style. This patch fails basic checkpatch.
WARNING: suspect code indent for conditional statements (8, 11)
#31: FILE: tc/tc_qdisc.c:241:
+ if (!show_raw) {
+ fprintf(fp, "qdisc %s %x: ", rta_getattr_str(tb[TCA_KIND]),
total: 0 errors, 1 warnings, 15 lines checked
next prev parent reply other threads:[~2016-11-13 6:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 15:06 [PATCH iproute2 1/1] tc: print raw qdisc handle Roman Mashak
2016-11-13 6:53 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-11-07 2:16 Roman Mashak
2016-11-07 13:13 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161113095337.1ac19e42@samsung9 \
--to=stephen@networkplumber.org \
--cc=jhs@mojatatu.com \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).