* [PATCH] amd-xgbe: fix unsigned comparison against less than zero
@ 2016-11-15 12:18 Colin King
2016-11-15 14:09 ` Tom Lendacky
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2016-11-15 12:18 UTC (permalink / raw)
To: Tom Lendacky, netdev; +Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Comparing unsigned int ret to less than zero for an error status
check is never true. Fix this by making ret a signed int. Reduce
scope of ret too.
Found with static analysis by CoverityScan, CID 1377750
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c
index 4ba4332..168507e 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c
+++ b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c
@@ -2346,7 +2346,7 @@ static bool xgbe_phy_valid_speed(struct xgbe_prv_data *pdata, int speed)
static int xgbe_phy_link_status(struct xgbe_prv_data *pdata, int *an_restart)
{
struct xgbe_phy_data *phy_data = pdata->phy_data;
- unsigned int ret, reg;
+ unsigned int reg;
*an_restart = 0;
@@ -2365,7 +2365,8 @@ static int xgbe_phy_link_status(struct xgbe_prv_data *pdata, int *an_restart)
if (phy_data->phydev) {
/* Check external PHY */
- ret = phy_read_status(phy_data->phydev);
+ int ret = phy_read_status(phy_data->phydev);
+
if (ret < 0)
return 0;
--
2.10.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] amd-xgbe: fix unsigned comparison against less than zero
2016-11-15 12:18 [PATCH] amd-xgbe: fix unsigned comparison against less than zero Colin King
@ 2016-11-15 14:09 ` Tom Lendacky
0 siblings, 0 replies; 2+ messages in thread
From: Tom Lendacky @ 2016-11-15 14:09 UTC (permalink / raw)
To: Colin King, netdev; +Cc: linux-kernel
On 11/15/2016 6:18 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Comparing unsigned int ret to less than zero for an error status
> check is never true. Fix this by making ret a signed int. Reduce
> scope of ret too.
>
> Found with static analysis by CoverityScan, CID 1377750
Thanks Colin, this was already identified by someone else and I
submitted the patch yesterday.
Thanks,
Tom
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c
> index 4ba4332..168507e 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c
> @@ -2346,7 +2346,7 @@ static bool xgbe_phy_valid_speed(struct xgbe_prv_data *pdata, int speed)
> static int xgbe_phy_link_status(struct xgbe_prv_data *pdata, int *an_restart)
> {
> struct xgbe_phy_data *phy_data = pdata->phy_data;
> - unsigned int ret, reg;
> + unsigned int reg;
>
> *an_restart = 0;
>
> @@ -2365,7 +2365,8 @@ static int xgbe_phy_link_status(struct xgbe_prv_data *pdata, int *an_restart)
>
> if (phy_data->phydev) {
> /* Check external PHY */
> - ret = phy_read_status(phy_data->phydev);
> + int ret = phy_read_status(phy_data->phydev);
> +
> if (ret < 0)
> return 0;
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-15 14:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-15 12:18 [PATCH] amd-xgbe: fix unsigned comparison against less than zero Colin King
2016-11-15 14:09 ` Tom Lendacky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).