From: Jiri Benc <jbenc@redhat.com>
To: Pravin B Shelar <pshelar@ovn.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/7] vxlan: avoid checking socket multiple times.
Date: Tue, 15 Nov 2016 15:15:56 +0100 [thread overview]
Message-ID: <20161115151556.60bf4b99@griffin> (raw)
In-Reply-To: <1479098638-4921-3-git-send-email-pshelar@ovn.org>
Pravin,
please CC reviewers of the previous version when submitting a new
version. You'll get faster reviews that way.
On Sun, 13 Nov 2016 20:43:53 -0800, Pravin B Shelar wrote:
> @@ -2069,11 +2069,7 @@ static void vxlan_xmit_one(struct sk_buff *skb, struct net_device *dev,
> struct dst_entry *ndst;
> u32 rt6i_flags;
>
> - if (!sock6)
> - goto drop;
> - sk = sock6->sock->sk;
> -
> - ndst = vxlan6_get_route(vxlan, skb,
> + ndst = vxlan6_get_route(vxlan, sock6, skb,
> rdst ? rdst->remote_ifindex : 0, tos,
> label, &dst->sin6.sin6_addr,
> &src->sin6.sin6_addr,
> @@ -2093,6 +2089,7 @@ static void vxlan_xmit_one(struct sk_buff *skb, struct net_device *dev,
> goto tx_error;
> }
>
> + sk = sock6->sock->sk;
> /* Bypass encapsulation if the destination is local */
> rt6i_flags = ((struct rt6_info *)ndst)->rt6i_flags;
> if (!info && rt6i_flags & RTF_LOCAL &&
This moves the sk assignment from one arbitrary place to a different
arbitrary place, while it would be best to just remove it and open code
sock6->sock->sk in the call to udp_tunnel6_xmit_skb. But patch 6 does
that later, so whatever.
Acked-by: Jiri Benc <jbenc@redhat.com>
next prev parent reply other threads:[~2016-11-15 14:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 4:43 [PATCH net-next v3 0/7] vxlan: xmit improvements Pravin B Shelar
2016-11-14 4:43 ` [PATCH net-next v3 1/7] vxlan: avoid vlan processing in vxlan device Pravin B Shelar
2016-11-14 4:43 ` [PATCH net-next v3 2/7] vxlan: avoid checking socket multiple times Pravin B Shelar
2016-11-15 14:15 ` Jiri Benc [this message]
2016-11-14 4:43 ` [PATCH net-next v3 3/7] vxlan: simplify exception handling Pravin B Shelar
2016-11-15 14:30 ` Jiri Benc
2016-11-15 16:40 ` Pravin Shelar
2016-11-15 17:04 ` Jiri Benc
2016-11-15 17:15 ` Pravin Shelar
2016-11-14 4:43 ` [PATCH net-next v3 4/7] vxlan: improve vxlan route lookup checks Pravin B Shelar
2016-11-15 14:39 ` Jiri Benc
2016-11-17 10:17 ` David Laight
2016-11-17 15:59 ` Jiri Benc
2016-11-17 18:11 ` David Miller
2016-11-21 20:34 ` Pravin Shelar
2016-11-18 5:30 ` Pravin Shelar
2016-11-14 4:43 ` [PATCH net-next v3 5/7] vxlan: simplify RTF_LOCAL handling Pravin B Shelar
2016-11-15 14:44 ` Jiri Benc
2016-11-14 4:43 ` [PATCH net-next v3 6/7] vxlan: simplify vxlan xmit Pravin B Shelar
2016-11-14 4:43 ` [PATCH net-next v3 7/7] vxlan: remove unsed vxlan_dev_dst_port() Pravin B Shelar
2016-11-15 14:56 ` Jiri Benc
2016-11-15 17:16 ` [PATCH net-next v3 0/7] vxlan: xmit improvements David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161115151556.60bf4b99@griffin \
--to=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).