From: David Miller <davem@davemloft.net>
To: andrew@lunn.ch
Cc: vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/6] Fixes for the MV88e6xxx interrupt code
Date: Wed, 16 Nov 2016 14:29:16 -0500 (EST) [thread overview]
Message-ID: <20161116.142916.1432429487379929901.davem@davemloft.net> (raw)
In-Reply-To: <20161116.142102.1586244273660874282.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Wed, 16 Nov 2016 14:21:02 -0500 (EST)
> From: Andrew Lunn <andrew@lunn.ch>
> Date: Wed, 16 Nov 2016 01:56:50 +0100
>
>> The interrupt code was never tested with a board who's probing
>> resulted in an -EPROBE_DEFFERED. So the clean up paths never got
>> tested. I now do have -EPROBE_DEFFERED, and things break badly during
>> cleanup. These are the fixes.
>>
>> This is fixing code in net-next.
>
> Series applied, thanks Andrew.
Actually, I reverted, there is a bug.
Take a look at how the 'device_irq' local variable is used in
mv88e6xxx_g2_irq_setup. You assign it to 'err' in an error
path before it is ever set to anything.
I think you meant to use the structure's 'device_irq' member
instead.
next prev parent reply other threads:[~2016-11-16 19:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 0:56 [PATCH net-next 0/6] Fixes for the MV88e6xxx interrupt code Andrew Lunn
2016-11-16 0:56 ` [PATCH net-next 1/6] net: dsa: mv88e6xxx: Fix typos when removing g1 interrupts Andrew Lunn
2016-11-16 0:56 ` [PATCH net-next 2/6] net: dsa: mv88e6xxx: Fix unconditional irq freeing Andrew Lunn
2016-11-16 0:56 ` [PATCH net-next 3/6] net: dsa: mv88e6xxx: Mask g1 interrupts and free interrupt Andrew Lunn
2016-11-16 0:56 ` [PATCH net-next 4/6] net: dsa: mv88e6xxx: Fix releasing for the global2 interrupts Andrew Lunn
2016-11-16 0:56 ` [PATCH net-next 5/6] net: dsa: mv88e6xxx: Fix cleanup on error for g1 interrupt setup Andrew Lunn
2016-11-16 0:56 ` [PATCH net-next 6/6] net: dsa: mv88e6xxx: Hold the mutex while freeing g1 interrupts Andrew Lunn
2016-11-16 19:21 ` [PATCH net-next 0/6] Fixes for the MV88e6xxx interrupt code David Miller
2016-11-16 19:29 ` David Miller [this message]
2016-11-16 19:45 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161116.142916.1432429487379929901.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).