* [PATCH] net: dsa: mv88e6xxx: Respect SPEED_UNFORCED, don't set force bit
@ 2016-11-16 3:26 Andrew Lunn
2016-11-16 19:34 ` David Miller
2016-11-17 3:25 ` Vivien Didelot
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Lunn @ 2016-11-16 3:26 UTC (permalink / raw)
To: David Miller; +Cc: Vivien Didelot, netdev, Andrew Lunn
The SPEED_UNFORCED indicates the MAC & PHY should perform
auto-negotiation to determine a speed which works. If this is called
for, don't set the force bit. If it is set, the MAC actually does
10Gbps, why the internal PHYs don't support.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/dsa/mv88e6xxx/port.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx/port.c b/drivers/net/dsa/mv88e6xxx/port.c
index e4978f6367aa..af4772d86086 100644
--- a/drivers/net/dsa/mv88e6xxx/port.c
+++ b/drivers/net/dsa/mv88e6xxx/port.c
@@ -213,7 +213,7 @@ static int mv88e6xxx_port_set_speed(struct mv88e6xxx_chip *chip, int port,
reg &= ~PORT_PCS_CTRL_ALTSPEED;
if (force_bit) {
reg &= ~PORT_PCS_CTRL_FORCE_SPEED;
- if (speed)
+ if (speed != SPEED_UNFORCED)
ctrl |= PORT_PCS_CTRL_FORCE_SPEED;
}
reg |= ctrl;
--
2.10.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: dsa: mv88e6xxx: Respect SPEED_UNFORCED, don't set force bit
2016-11-16 3:26 [PATCH] net: dsa: mv88e6xxx: Respect SPEED_UNFORCED, don't set force bit Andrew Lunn
@ 2016-11-16 19:34 ` David Miller
2016-11-17 3:25 ` Vivien Didelot
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-11-16 19:34 UTC (permalink / raw)
To: andrew; +Cc: vivien.didelot, netdev
From: Andrew Lunn <andrew@lunn.ch>
Date: Wed, 16 Nov 2016 04:26:48 +0100
> The SPEED_UNFORCED indicates the MAC & PHY should perform
> auto-negotiation to determine a speed which works. If this is called
> for, don't set the force bit. If it is set, the MAC actually does
> 10Gbps, why the internal PHYs don't support.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
What tree is this for? This is a fix but the patch doesn't apply to
'net'.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: mv88e6xxx: Respect SPEED_UNFORCED, don't set force bit
2016-11-16 3:26 [PATCH] net: dsa: mv88e6xxx: Respect SPEED_UNFORCED, don't set force bit Andrew Lunn
2016-11-16 19:34 ` David Miller
@ 2016-11-17 3:25 ` Vivien Didelot
1 sibling, 0 replies; 3+ messages in thread
From: Vivien Didelot @ 2016-11-17 3:25 UTC (permalink / raw)
To: Andrew Lunn, David Miller; +Cc: netdev, Andrew Lunn
Hi Andrew,
Andrew Lunn <andrew@lunn.ch> writes:
> The SPEED_UNFORCED indicates the MAC & PHY should perform
> auto-negotiation to determine a speed which works. If this is called
> for, don't set the force bit. If it is set, the MAC actually does
> 10Gbps, why the internal PHYs don't support.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Fixes: 96a2b40c7bd3 ("net: dsa: mv88e6xxx: add port's MAC speed setter")
Reviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
David, this is for net-next.
Thanks!
Vivien
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-17 3:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-16 3:26 [PATCH] net: dsa: mv88e6xxx: Respect SPEED_UNFORCED, don't set force bit Andrew Lunn
2016-11-16 19:34 ` David Miller
2016-11-17 3:25 ` Vivien Didelot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).