* [PATCH] net: bcm63xx_enet: fix build failure
@ 2016-11-16 22:50 Sudip Mukherjee
2016-11-16 22:51 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Sudip Mukherjee @ 2016-11-16 22:50 UTC (permalink / raw)
To: Florian Fainelli, David S. Miller
Cc: linux-kernel, bcm-kernel-feedback-list, netdev, linux-arm-kernel,
Sudip Mukherjee
The build of mips bcm63xx_defconfig was failing with the error:
drivers/net/ethernet/broadcom/bcm63xx_enet.c:1440:2:
error: expected expression before 'return'
The return statement should be termibated with ';' and not ','.
Fixes: 42469bf5d9bb ("net: bcm63xx_enet: Utilize phy_ethtool_nway_reset")
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
build log is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/176269457
drivers/net/ethernet/broadcom/bcm63xx_enet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
index a43ab90..3b14d51 100644
--- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
+++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
@@ -1435,7 +1435,7 @@ static int bcm_enet_nway_reset(struct net_device *dev)
priv = netdev_priv(dev);
if (priv->has_phy)
- return phy_ethtool_nway_reset(dev),
+ return phy_ethtool_nway_reset(dev);
return -EOPNOTSUPP;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: bcm63xx_enet: fix build failure
2016-11-16 22:50 [PATCH] net: bcm63xx_enet: fix build failure Sudip Mukherjee
@ 2016-11-16 22:51 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-11-16 22:51 UTC (permalink / raw)
To: sudipm.mukherjee
Cc: f.fainelli, linux-kernel, bcm-kernel-feedback-list, netdev,
linux-arm-kernel
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date: Wed, 16 Nov 2016 22:50:16 +0000
> The build of mips bcm63xx_defconfig was failing with the error:
> drivers/net/ethernet/broadcom/bcm63xx_enet.c:1440:2:
> error: expected expression before 'return'
>
> The return statement should be termibated with ';' and not ','.
>
> Fixes: 42469bf5d9bb ("net: bcm63xx_enet: Utilize phy_ethtool_nway_reset")
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Already fixes in the current net-next tree.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-16 22:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-16 22:50 [PATCH] net: bcm63xx_enet: fix build failure Sudip Mukherjee
2016-11-16 22:51 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).