From: Andrew Lunn <andrew@lunn.ch>
To: Greentime Hu <green.hu@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: faraday: To support device tree usage.
Date: Wed, 16 Nov 2016 14:47:15 +0100 [thread overview]
Message-ID: <20161116134715.GE19962@lunn.ch> (raw)
In-Reply-To: <1479285795-3105-1-git-send-email-green.hu@gmail.com>
On Wed, Nov 16, 2016 at 04:43:15PM +0800, Greentime Hu wrote:
> To support device tree usage for ftmac100.
>
> Signed-off-by: Greentime Hu <green.hu@gmail.com>
> ---
> drivers/net/ethernet/faraday/ftmac100.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/net/ethernet/faraday/ftmac100.c b/drivers/net/ethernet/faraday/ftmac100.c
> index dce5f7b..81dd9e1 100644
> --- a/drivers/net/ethernet/faraday/ftmac100.c
> +++ b/drivers/net/ethernet/faraday/ftmac100.c
> @@ -1172,11 +1172,17 @@ static int __exit ftmac100_remove(struct platform_device *pdev)
> return 0;
> }
>
> +static const struct of_device_id mac_of_ids[] = {
> + { .compatible = "andestech,atmac100" },
> + { }
andestech is not in
Documentation/devicetree/bindings/vendor-prefixes.txt Please provide a
separate patch adding it.
Humm, why andestech? Why not something based around faraday
technology?
Andrew
next prev parent reply other threads:[~2016-11-16 13:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 8:43 [PATCH] net: ethernet: faraday: To support device tree usage Greentime Hu
2016-11-16 11:53 ` Jiri Pirko
2016-11-16 12:08 ` Greentime Hu
2016-11-16 12:16 ` Jiri Pirko
2016-11-16 13:47 ` Andrew Lunn [this message]
2016-11-16 14:26 ` Greentime Hu
2016-11-16 14:37 ` Andrew Lunn
[not found] ` <20161116143715.GH19962-g2DYL2Zd6BY@public.gmane.org>
2016-11-16 16:12 ` Arnd Bergmann
2016-11-17 2:37 ` Greentime Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161116134715.GE19962@lunn.ch \
--to=andrew@lunn.ch \
--cc=green.hu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).