* [patch net-next] liquidio CN23XX: bitwise vs logical AND typo
@ 2016-11-18 11:47 Dan Carpenter
2016-11-18 19:04 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-11-18 11:47 UTC (permalink / raw)
To: Derek Chickles, Raghu Vatsavayi
Cc: Satanand Burla, Felix Manlunas, netdev, kernel-janitors
We obviously intended a bitwise AND here, not a logical one.
Fixes: 8c978d059224 ("liquidio CN23XX: Mailbox support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c b/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c
index 5309384..73696b42 100644
--- a/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c
+++ b/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c
@@ -301,7 +301,7 @@ int octeon_mbox_process_message(struct octeon_mbox *mbox)
sizeof(struct octeon_mbox_cmd));
if (!mbox_cmd.msg.s.resp_needed) {
mbox->state &= ~OCTEON_MBOX_STATE_REQUEST_RECEIVED;
- if (!(mbox->state &&
+ if (!(mbox->state &
OCTEON_MBOX_STATE_RESPONSE_PENDING))
mbox->state = OCTEON_MBOX_STATE_IDLE;
writeq(OCTEON_PFVFSIG, mbox->mbox_read_reg);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch net-next] liquidio CN23XX: bitwise vs logical AND typo
2016-11-18 11:47 [patch net-next] liquidio CN23XX: bitwise vs logical AND typo Dan Carpenter
@ 2016-11-18 19:04 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-11-18 19:04 UTC (permalink / raw)
To: dan.carpenter
Cc: derek.chickles, raghu.vatsavayi, satananda.burla, felix.manlunas,
netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 18 Nov 2016 14:47:35 +0300
> We obviously intended a bitwise AND here, not a logical one.
>
> Fixes: 8c978d059224 ("liquidio CN23XX: Mailbox support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-18 19:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-18 11:47 [patch net-next] liquidio CN23XX: bitwise vs logical AND typo Dan Carpenter
2016-11-18 19:04 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).