From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: derek.chickles@caviumnetworks.com,
satananda.burla@caviumnetworks.com,
felix.manlunas@caviumnetworks.com,
raghu.vatsavayi@caviumnetworks.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] liquidio CN23XX: check if PENDING bit is clear using logical and
Date: Fri, 18 Nov 2016 14:04:16 -0500 (EST) [thread overview]
Message-ID: <20161118.140416.729970601759105910.davem@davemloft.net> (raw)
In-Reply-To: <20161118184532.5282-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Fri, 18 Nov 2016 18:45:32 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> the mbox state should be bitwise anded rather than logically anded
> with OCTEON_MBOX_STATE_RESPONSE_PENDING. Fix this by using the
> correct & operator instead of &&.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Dan Carpenter already submitted a fix for this.
prev parent reply other threads:[~2016-11-18 19:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 18:45 [PATCH] liquidio CN23XX: check if PENDING bit is clear using logical and Colin King
2016-11-18 19:04 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118.140416.729970601759105910.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=colin.king@canonical.com \
--cc=derek.chickles@caviumnetworks.com \
--cc=felix.manlunas@caviumnetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=raghu.vatsavayi@caviumnetworks.com \
--cc=satananda.burla@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).