From: David Miller <davem@davemloft.net>
To: jarno@ovn.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/5] virtio_net: Simplify call sites for virtio_net_hdr_{from,to}_skb().
Date: Sat, 19 Nov 2016 10:37:14 -0500 (EST) [thread overview]
Message-ID: <20161119.103714.293011246005811705.davem@davemloft.net> (raw)
In-Reply-To: <1479512442-61601-1-git-send-email-jarno@ovn.org>
From: Jarno Rajahalme <jarno@ovn.org>
Date: Fri, 18 Nov 2016 15:40:38 -0800
> No point storing the return value of virtio_net_hdr_to_skb() or
> virtio_net_hdr_from_skb() to a variable when the value is used only
> once as a boolean in an immediately following if statement.
>
> Signed-off-by: Jarno Rajahalme <jarno@ovn.org>
Applied.
prev parent reply other threads:[~2016-11-19 15:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 23:40 [PATCH net-next v2 1/5] virtio_net: Simplify call sites for virtio_net_hdr_{from,to}_skb() Jarno Rajahalme
2016-11-18 23:40 ` [PATCH net-next v2 2/5] virtio_net.h: Fix comment Jarno Rajahalme
2016-11-19 15:37 ` David Miller
2016-11-18 23:40 ` [PATCH net-next v2 3/5] virtio_net: Do not clear memory for struct virtio_net_hdr twice Jarno Rajahalme
2016-11-19 15:37 ` David Miller
2016-11-18 23:40 ` [PATCH net-next v2 4/5] af_packet: Use virtio_net_hdr_to_skb() Jarno Rajahalme
2016-11-19 15:37 ` David Miller
2016-11-18 23:40 ` [PATCH net-next v2 5/5] af_packet: Use virtio_net_hdr_from_skb() directly Jarno Rajahalme
2016-11-19 15:37 ` David Miller
2016-11-19 15:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161119.103714.293011246005811705.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jarno@ovn.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).