From: David Miller <davem@davemloft.net>
To: fw@strlen.de
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 next 0/2] tcp: make undo_cwnd mandatory for congestion modules
Date: Mon, 21 Nov 2016 13:20:33 -0500 (EST) [thread overview]
Message-ID: <20161121.132033.2109447661537445700.davem@davemloft.net> (raw)
In-Reply-To: <1479734318-30607-1-git-send-email-fw@strlen.de>
From: Florian Westphal <fw@strlen.de>
Date: Mon, 21 Nov 2016 14:18:36 +0100
> highspeed, illinois, scalable, veno and yeah congestion control algorithms
> don't provide a 'cwnd_undo' function. This makes the stack default to a
> 'reno undo' which doubles cwnd. However, the ssthresh implementation of
> these algorithms do not halve the slowstart threshold. This causes similar
> issue as the one fixed for dctcp in ce6dd23329b1e ("dctcp: avoid bogus
> doubling of cwnd after loss").
>
> In light of this it seems better to remove the fallback and make undo_cwnd
> mandatory.
>
> First patch fixes those spots where reno undo seems incorrect by providing
> .cwnd_undo functions, second patch removes the fallback.
Series applied, thanks for following up on this.
prev parent reply other threads:[~2016-11-21 18:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 13:18 [PATCH v2 next 0/2] tcp: make undo_cwnd mandatory for congestion modules Florian Westphal
2016-11-21 13:18 ` [PATCH next 1/2] tcp: add cwnd_undo functions to various tcp cc algorithms Florian Westphal
2016-11-21 13:18 ` [PATCH next v2 2/2] tcp: make undo_cwnd mandatory for congestion modules Florian Westphal
2016-11-21 18:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161121.132033.2109447661537445700.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).