From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: maan@tuebingen.mpg.de, jiri@resnulli.us,
alexander.h.duyck@intel.com, edumazet@google.com,
linux-kernel@vger.kernel.org, ast@kernel.org, willemb@google.com,
gregkh@linuxfoundation.org, jslaby@suse.cz, yibyang@cisco.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net] flow_dissect: call init_default_flow_dissectors() earlier
Date: Tue, 22 Nov 2016 14:44:44 -0500 (EST) [thread overview]
Message-ID: <20161122.144444.2261159964230408258.davem@davemloft.net> (raw)
In-Reply-To: <1479842250.8455.452.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 22 Nov 2016 11:17:30 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> Andre Noll reported panics after my recent fix (commit 34fad54c2537
> "net: __skb_flow_dissect() must cap its return value")
>
> After some more headaches, Alexander root caused the problem to
> init_default_flow_dissectors() being called too late, in case
> a network driver like IGB is not a module and receives DHCP message
> very early.
>
> Fix is to call init_default_flow_dissectors() much earlier,
> as it is a core infrastructure and does not depend on another
> kernel service.
>
> Fixes: 06635a35d13d4 ("flow_dissect: use programable dissector in skb_flow_dissect and friends")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Andre Noll <maan@tuebingen.mpg.de>
> Diagnosed-by: Alexander Duyck <alexander.h.duyck@intel.com>
Applied and queued up for -stable, I'll try to fast-track this.
prev parent reply other threads:[~2016-11-22 19:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161121092855.GA20976@kroah.com>
[not found] ` <20161122165912.GA19939@tuebingen.mpg.de>
[not found] ` <20161122170654.GA20022@kroah.com>
[not found] ` <CANn89iJCkHxOpE3TW8+gW8+UCVvT0mY8y8j_GJC1GK0i05dgbg@mail.gmail.com>
[not found] ` <1479836511.681.165.camel@intel.com>
[not found] ` <CANn89iLdtfoYDVoszduyKCpmZpYcpV2=UnwbjAzH0G08nzNwbw@mail.gmail.com>
[not found] ` <20161122175504.GD19939@tuebingen.mpg.de>
[not found] ` <CANn89iKZMcnzLJUNE286pBKSaL3kcrBgwpdihxSMm8Ze5L_-qw@mail.gmail.com>
[not found] ` <20161122180605.GE19939@tuebingen.mpg.de>
[not found] ` <1479838123.681.173.camel@intel.com>
[not found] ` <20161122182258.GF19939@tuebingen.mpg.de>
2016-11-22 19:17 ` [PATCH net] flow_dissect: call init_default_flow_dissectors() earlier Eric Dumazet
2016-11-22 19:44 ` Andre Noll
2016-11-22 19:44 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122.144444.2261159964230408258.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=ast@kernel.org \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiri@resnulli.us \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=maan@tuebingen.mpg.de \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=yibyang@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).