* [PATCH net] flow_dissect: call init_default_flow_dissectors() earlier [not found] ` <20161122182258.GF19939@tuebingen.mpg.de> @ 2016-11-22 19:17 ` Eric Dumazet 2016-11-22 19:44 ` Andre Noll 2016-11-22 19:44 ` David Miller 0 siblings, 2 replies; 3+ messages in thread From: Eric Dumazet @ 2016-11-22 19:17 UTC (permalink / raw) To: Andre Noll, Jiri Pirko Cc: Duyck, Alexander H, edumazet@google.com, linux-kernel@vger.kernel.org, ast@kernel.org, willemb@google.com, gregkh@linuxfoundation.org, jslaby@suse.cz, davem@davemloft.net, yibyang@cisco.com, netdev From: Eric Dumazet <edumazet@google.com> Andre Noll reported panics after my recent fix (commit 34fad54c2537 "net: __skb_flow_dissect() must cap its return value") After some more headaches, Alexander root caused the problem to init_default_flow_dissectors() being called too late, in case a network driver like IGB is not a module and receives DHCP message very early. Fix is to call init_default_flow_dissectors() much earlier, as it is a core infrastructure and does not depend on another kernel service. Fixes: 06635a35d13d4 ("flow_dissect: use programable dissector in skb_flow_dissect and friends") Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: Andre Noll <maan@tuebingen.mpg.de> Diagnosed-by: Alexander Duyck <alexander.h.duyck@intel.com> --- net/core/flow_dissector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index 69e4463a4b1b..c6d8207ffa7e 100644 --- a/net/core/flow_dissector.c +++ b/net/core/flow_dissector.c @@ -1013,4 +1013,4 @@ static int __init init_default_flow_dissectors(void) return 0; } -late_initcall_sync(init_default_flow_dissectors); +core_initcall(init_default_flow_dissectors); ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] flow_dissect: call init_default_flow_dissectors() earlier 2016-11-22 19:17 ` [PATCH net] flow_dissect: call init_default_flow_dissectors() earlier Eric Dumazet @ 2016-11-22 19:44 ` Andre Noll 2016-11-22 19:44 ` David Miller 1 sibling, 0 replies; 3+ messages in thread From: Andre Noll @ 2016-11-22 19:44 UTC (permalink / raw) To: Eric Dumazet Cc: Jiri Pirko, Duyck, Alexander H, edumazet@google.com, linux-kernel@vger.kernel.org, ast@kernel.org, willemb@google.com, gregkh@linuxfoundation.org, jslaby@suse.cz, davem@davemloft.net, yibyang@cisco.com, netdev [-- Attachment #1: Type: text/plain, Size: 424 bytes --] On Tue, Nov 22, 11:17, Eric Dumazet wrote > -late_initcall_sync(init_default_flow_dissectors); > +core_initcall(init_default_flow_dissectors); Indeed, that fixed it. Feel free to add Tested-by: Andre Noll <maan@tuebingen.mpg.de> Thanks a lot Andre -- Max Planck Institute for Developmental Biology Spemannstraße 35, 72076 Tübingen, Germany. Phone: (+49) 7071 601 829 http://people.tuebingen.mpg.de/maan/ [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 181 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] flow_dissect: call init_default_flow_dissectors() earlier 2016-11-22 19:17 ` [PATCH net] flow_dissect: call init_default_flow_dissectors() earlier Eric Dumazet 2016-11-22 19:44 ` Andre Noll @ 2016-11-22 19:44 ` David Miller 1 sibling, 0 replies; 3+ messages in thread From: David Miller @ 2016-11-22 19:44 UTC (permalink / raw) To: eric.dumazet Cc: maan, jiri, alexander.h.duyck, edumazet, linux-kernel, ast, willemb, gregkh, jslaby, yibyang, netdev From: Eric Dumazet <eric.dumazet@gmail.com> Date: Tue, 22 Nov 2016 11:17:30 -0800 > From: Eric Dumazet <edumazet@google.com> > > Andre Noll reported panics after my recent fix (commit 34fad54c2537 > "net: __skb_flow_dissect() must cap its return value") > > After some more headaches, Alexander root caused the problem to > init_default_flow_dissectors() being called too late, in case > a network driver like IGB is not a module and receives DHCP message > very early. > > Fix is to call init_default_flow_dissectors() much earlier, > as it is a core infrastructure and does not depend on another > kernel service. > > Fixes: 06635a35d13d4 ("flow_dissect: use programable dissector in skb_flow_dissect and friends") > Signed-off-by: Eric Dumazet <edumazet@google.com> > Reported-by: Andre Noll <maan@tuebingen.mpg.de> > Diagnosed-by: Alexander Duyck <alexander.h.duyck@intel.com> Applied and queued up for -stable, I'll try to fast-track this. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-22 19:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20161121092855.GA20976@kroah.com>
[not found] ` <20161122165912.GA19939@tuebingen.mpg.de>
[not found] ` <20161122170654.GA20022@kroah.com>
[not found] ` <CANn89iJCkHxOpE3TW8+gW8+UCVvT0mY8y8j_GJC1GK0i05dgbg@mail.gmail.com>
[not found] ` <1479836511.681.165.camel@intel.com>
[not found] ` <CANn89iLdtfoYDVoszduyKCpmZpYcpV2=UnwbjAzH0G08nzNwbw@mail.gmail.com>
[not found] ` <20161122175504.GD19939@tuebingen.mpg.de>
[not found] ` <CANn89iKZMcnzLJUNE286pBKSaL3kcrBgwpdihxSMm8Ze5L_-qw@mail.gmail.com>
[not found] ` <20161122180605.GE19939@tuebingen.mpg.de>
[not found] ` <1479838123.681.173.camel@intel.com>
[not found] ` <20161122182258.GF19939@tuebingen.mpg.de>
2016-11-22 19:17 ` [PATCH net] flow_dissect: call init_default_flow_dissectors() earlier Eric Dumazet
2016-11-22 19:44 ` Andre Noll
2016-11-22 19:44 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).