From: Steffen Klassert <steffen.klassert@secunet.com>
To: Miroslav Urbanek <mu@miroslavurbanek.com>
Cc: NetDev <netdev@vger.kernel.org>
Subject: Re: [PATCH] flowcache: Increase threshold for refusing new allocations
Date: Wed, 23 Nov 2016 13:42:55 +0100 [thread overview]
Message-ID: <20161123124255.GA3541@gauss.secunet.com> (raw)
In-Reply-To: <20161121144820.GA4048@miroslavurbanek.com>
On Mon, Nov 21, 2016 at 03:48:21PM +0100, Miroslav Urbanek wrote:
> The threshold for OOM protection is too small for systems with large
> number of CPUs. Applications report ENOBUFs on connect() every 10
> minutes.
>
> The problem is that the variable net->xfrm.flow_cache_gc_count is a
> global counter while the variable fc->high_watermark is a per-CPU
> constant. Take the number of CPUs into account as well.
>
> Fixes: 6ad3122a08e3 ("flowcache: Avoid OOM condition under preasure")
> Reported-by: Lukáš Koldrt <lk@excello.cz>
> Tested-by: Jan Hejl <jh@excello.cz>
> Signed-off-by: Miroslav Urbanek <mu@miroslavurbanek.com>
Applied to the ipsec tree, thanks!
prev parent reply other threads:[~2016-11-23 12:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 14:48 [PATCH] flowcache: Increase threshold for refusing new allocations Miroslav Urbanek
2016-11-23 12:42 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161123124255.GA3541@gauss.secunet.com \
--to=steffen.klassert@secunet.com \
--cc=mu@miroslavurbanek.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox