From: "John W. Linville" <linville@tuxdriver.com>
To: "Allan W. Nielsen" <allan.nielsen@microsemi.com>
Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com,
raju.lakkaraju@microsemi.com
Subject: Re: [PATCH ethtool v4 1/2] ethtool-copy.h:sync with net
Date: Wed, 23 Nov 2016 10:55:07 -0500 [thread overview]
Message-ID: <20161123155506.GD13179@tuxdriver.com> (raw)
In-Reply-To: <20161123152447.GC13179@tuxdriver.com>
On Wed, Nov 23, 2016 at 10:24:47AM -0500, John W. Linville wrote:
> It looks like this patch somehow misses the following commit:
>
> commit 85a624403c77c3f074931aefdfced59f61b668cb
> Author: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Date: Thu Oct 13 16:13:55 2016 -0700
>
> ethtool: silence warning on bit loss
>
> Sparse was complaining when we went to prototype some code
> using ethtool_cmd_speed_set and SPEED_100000, which uses
> the upper 16 bits of __u32 speed for the first time.
>
> CHECK
> ...
> .../uapi/linux/ethtool.h:123:28: warning:
> cast truncates bits from constant value (186a0 becomes 86a0)
>
> The warning is actually bogus, as no bits are really lost, but
> we can get rid of the sparse warning with this one small change.
>
> Reported-by: Preethi Banala <preethi.banala@intel.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> Plus, the referenced commit does not seem to exist in the net-next tree.
>
> Please resubmit with the complete history and correct commit IDs -- thanks!
I mean, of course, all the preceding changes accounted for -- not
every commit explicitly listed. The top commit does, of course,
need to reflect the correct commit ID from Dave's/Linus's tree.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2016-11-23 16:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 20:32 [PATCH ethtool v4 0/2] Adding downshift support to ethtool Allan W. Nielsen
2016-11-22 20:32 ` [PATCH ethtool v4 1/2] ethtool-copy.h:sync with net Allan W. Nielsen
2016-11-23 15:24 ` John W. Linville
2016-11-23 15:55 ` John W. Linville [this message]
2016-11-22 20:32 ` [PATCH ethtool v4 2/2] Ethtool: Implements ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE and PHY downshift Allan W. Nielsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161123155506.GD13179@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=allan.nielsen@microsemi.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=raju.lakkaraju@microsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).