From: Phil Sutter <phil@nwl.cc>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Sabrina Dubroca <sd@queasysnail.net>
Subject: Re: [net-next PATCH v3] net: dummy: Introduce dummy virtual functions
Date: Wed, 23 Nov 2016 17:24:30 +0100 [thread overview]
Message-ID: <20161123162430.GD6158@orbyte.nwl.cc> (raw)
In-Reply-To: <1479907588.8455.484.camel@edumazet-glaptop3.roam.corp.google.com>
On Wed, Nov 23, 2016 at 05:26:28AM -0800, Eric Dumazet wrote:
> On Wed, 2016-11-23 at 13:41 +0100, Phil Sutter wrote:
>
> > +struct vf_data_storage {
> > + unsigned char vf_mac[ETH_ALEN];
> > + u16 pf_vlan; /* When set, guest VLAN config not allowed. */
> > + u16 pf_qos;
> > + __be16 vlan_proto;
> > + u16 min_tx_rate;
> > + u16 max_tx_rate;
> > + u8 spoofchk_enabled;
> > + bool rss_query_enabled;
> > + u8 trusted;
> > + int link_state;
> > +};
>
> Could you use proper indentation of field names ?
Sure!
> struct vf_data_storage {
> u8 vf_mac[ETH_ALEN];
Also thanks for suggesting u8 here. I really shouldn't copy'n'paste
code, not even from a well-maintained driver.
Thanks, Phil
prev parent reply other threads:[~2016-11-23 16:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 12:41 [net-next PATCH v3] net: dummy: Introduce dummy virtual functions Phil Sutter
2016-11-23 13:26 ` Eric Dumazet
2016-11-23 16:24 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161123162430.GD6158@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).