From: Andrew Lunn <andrew@lunn.ch>
To: Stefan Eichenberger <stefan.eichenberger@netmodule.com>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Stefan Eichenberger <eichest@gmail.com>,
f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: dsa: mv88e6xxx: egress all frames
Date: Wed, 23 Nov 2016 17:58:14 +0100 [thread overview]
Message-ID: <20161123165814.GA8760@lunn.ch> (raw)
In-Reply-To: <20161123165022.GD12698@gruene.netmodule.intranet>
> 9:8 Frame Mode: 00 -> Normal Network
> 01 -> DSA (FRAME_MODE_DSA)
> 10 -> Provider (FRAME_MODE_PROVIDER)
> 11 -> Ether Type DSA (FRAME_ETHER_TYPE_DSA)
Ah, there is one issue. This device supports EDSA. However,
MV88E6XXX_FLAGS_FAMILY_6097 does not list MV88E6XXX_FLAG_EDSA.
Without that flag set, the code assumes the device can only do DSA,
using the older definition of this register.
Andrew
prev parent reply other threads:[~2016-11-23 16:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 10:39 [PATCH] net: dsa: mv88e6xxx: egress all frames Stefan Eichenberger
2016-11-22 15:03 ` Andrew Lunn
2016-11-22 18:37 ` Stefan Eichenberger
2016-11-22 19:02 ` Andrew Lunn
2016-11-22 22:15 ` Vivien Didelot
2016-11-23 9:56 ` Stefan Eichenberger
2016-11-23 12:00 ` Stefan Eichenberger
2016-11-23 15:59 ` Vivien Didelot
2016-11-23 16:50 ` Stefan Eichenberger
2016-11-23 16:54 ` [PATCH v2] net: dsa: mv88e6xxx: forward unknown mc packets on mv88e6097 Stefan Eichenberger
2016-11-23 16:59 ` Andrew Lunn
2016-11-23 17:11 ` [PATCH v3] net: dsa: mv88e6xxx: enable EDSA " Stefan Eichenberger
2016-11-23 17:13 ` Andrew Lunn
2016-11-23 17:14 ` [PATCH v2] net: dsa: mv88e6xxx: forward unknown mc packets " Stefan Eichenberger
2016-11-23 17:32 ` Andrew Lunn
2016-11-23 17:49 ` Stefan Eichenberger
2016-11-23 17:40 ` Andrew Lunn
2016-11-23 17:52 ` Vivien Didelot
2016-11-23 18:01 ` Andrew Lunn
2016-11-23 18:18 ` Vivien Didelot
2016-11-23 16:58 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161123165814.GA8760@lunn.ch \
--to=andrew@lunn.ch \
--cc=eichest@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stefan.eichenberger@netmodule.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).