From: Stefan Eichenberger <stefan.eichenberger@netmodule.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Stefan Eichenberger <eichest@gmail.com>,
<vivien.didelot@savoirfairelinux.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH 1/2] net: dsa: mv88e6xxx: add MV88E6097 switch
Date: Wed, 23 Nov 2016 21:41:46 +0100 [thread overview]
Message-ID: <20161123204146.GA31777@gruene.netmodule.intranet> (raw)
In-Reply-To: <20161123181016.GG8760@lunn.ch>
On Wed, Nov 23, 2016 at 07:10:16PM +0100, Andrew Lunn wrote:
> > + [MV88E6097] = {
> > + .prod_num = PORT_SWITCH_ID_PROD_NUM_6097,
> > + .family = MV88E6XXX_FAMILY_6097,
> > + .name = "Marvell 88E6097/88E6097F",
> > + .num_databases = 4096,
> > + .num_ports = 11,
> > + .port_base_addr = 0x10,
> > + .global1_addr = 0x1b,
> > + .age_time_coeff = 15000,
> > + .flags = MV88E6XXX_FLAGS_FAMILY_6097,
> > + .ops = &mv88e6097_ops,
>
> Upps. Sorry, i missed something when you rebased onto net-next. You
> are missing .g1_irqs = . It is probably 9. You can check the
> datasheet, global 1, register 0. If bit 8 is AVBInt, you need 9. If
> bit 8 is reserved, then 8.
No problem, bit 8-10 are reserved. So I put 8 in then.
Regards,
Stefan
next prev parent reply other threads:[~2016-11-23 20:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 17:55 [PATCH net-next 0/2] Add support for the MV88e6097 Stefan Eichenberger
2016-11-23 17:55 ` [PATCH 1/2] net: dsa: mv88e6xxx: add MV88E6097 switch Stefan Eichenberger
2016-11-23 18:10 ` Andrew Lunn
2016-11-23 20:41 ` Stefan Eichenberger [this message]
2016-11-23 17:55 ` [PATCH 2/2] net: dsa: mv88e6xxx: enable EDSA on mv88e6097 Stefan Eichenberger
2016-11-23 18:10 ` Andrew Lunn
2016-11-23 18:21 ` Vivien Didelot
2016-11-23 18:09 ` [PATCH net-next 0/2] Add support for the MV88e6097 Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161123204146.GA31777@gruene.netmodule.intranet \
--to=stefan.eichenberger@netmodule.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=eichest@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).