From: David Miller <davem@davemloft.net>
To: ast@fb.com
Cc: daniel@iogearbox.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] samples/bpf: fix sockex2 example
Date: Thu, 24 Nov 2016 16:05:04 -0500 (EST) [thread overview]
Message-ID: <20161124.160504.2054406480214878235.davem@davemloft.net> (raw)
In-Reply-To: <1479862329-2361912-1-git-send-email-ast@fb.com>
From: Alexei Starovoitov <ast@fb.com>
Date: Tue, 22 Nov 2016 16:52:08 -0800
> since llvm commit "Do not expand UNDEF SDNode during insn selection lowering"
> llvm will generate code that uses uninitialized registers for cases
> where C code is actually uses uninitialized data.
> So this sockex2 example is technically broken.
> Fix it by initializing on the stack variable fully.
> Also increase verifier buffer limit, since verifier output
> may not fit in 64k for this sockex2 code depending on llvm version.
>
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Applied.
prev parent reply other threads:[~2016-11-24 21:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 0:52 [PATCH net-next 1/2] samples/bpf: fix sockex2 example Alexei Starovoitov
2016-11-23 0:52 ` [PATCH net-next 2/2] samples/bpf: fix bpf loader Alexei Starovoitov
2016-11-23 9:57 ` Daniel Borkmann
2016-11-24 21:05 ` David Miller
2016-11-23 9:58 ` [PATCH net-next 1/2] samples/bpf: fix sockex2 example Daniel Borkmann
2016-11-24 21:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124.160504.2054406480214878235.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).