* [PATCH net 1/1] net sched filters: fix filter handle ID in tfilter_notify_chain()
@ 2016-11-23 1:57 Roman Mashak
2016-11-23 4:09 ` Cong Wang
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Roman Mashak @ 2016-11-23 1:57 UTC (permalink / raw)
To: davem; +Cc: netdev, jhs, xiyou.wangcong, daniel, Roman Mashak
Should pass valid filter handle, not the netlink flags.
Fixes: 30a391a13ab92 ("net sched filters: pass netlink message flags in event notification")
Signed-off-by: Roman Mashak <mrv@mojatatu.com>
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
---
net/sched/cls_api.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index 8e93d4a..b05d4a2 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -112,7 +112,7 @@ static void tfilter_notify_chain(struct net *net, struct sk_buff *oskb,
for (it_chain = chain; (tp = rtnl_dereference(*it_chain)) != NULL;
it_chain = &tp->next)
- tfilter_notify(net, oskb, n, tp, n->nlmsg_flags, event, false);
+ tfilter_notify(net, oskb, n, tp, 0, event, false);
}
/* Select new prio value from the range, managed by kernel. */
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net 1/1] net sched filters: fix filter handle ID in tfilter_notify_chain()
2016-11-23 1:57 [PATCH net 1/1] net sched filters: fix filter handle ID in tfilter_notify_chain() Roman Mashak
@ 2016-11-23 4:09 ` Cong Wang
2016-11-23 7:34 ` Daniel Borkmann
2016-11-24 21:06 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Cong Wang @ 2016-11-23 4:09 UTC (permalink / raw)
To: Roman Mashak
Cc: David Miller, Linux Kernel Network Developers, Jamal Hadi Salim,
Daniel Borkmann
On Tue, Nov 22, 2016 at 5:57 PM, Roman Mashak <mrv@mojatatu.com> wrote:
> Should pass valid filter handle, not the netlink flags.
>
> Fixes: 30a391a13ab92 ("net sched filters: pass netlink message flags in event notification")
> Signed-off-by: Roman Mashak <mrv@mojatatu.com>
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
Reported-by: Cong Wang <xiyou.wangcong@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net 1/1] net sched filters: fix filter handle ID in tfilter_notify_chain()
2016-11-23 1:57 [PATCH net 1/1] net sched filters: fix filter handle ID in tfilter_notify_chain() Roman Mashak
2016-11-23 4:09 ` Cong Wang
@ 2016-11-23 7:34 ` Daniel Borkmann
2016-11-24 21:06 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Borkmann @ 2016-11-23 7:34 UTC (permalink / raw)
To: Roman Mashak, davem; +Cc: netdev, jhs, xiyou.wangcong
On 11/23/2016 02:57 AM, Roman Mashak wrote:
> Should pass valid filter handle, not the netlink flags.
>
> Fixes: 30a391a13ab92 ("net sched filters: pass netlink message flags in event notification")
> Signed-off-by: Roman Mashak <mrv@mojatatu.com>
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net 1/1] net sched filters: fix filter handle ID in tfilter_notify_chain()
2016-11-23 1:57 [PATCH net 1/1] net sched filters: fix filter handle ID in tfilter_notify_chain() Roman Mashak
2016-11-23 4:09 ` Cong Wang
2016-11-23 7:34 ` Daniel Borkmann
@ 2016-11-24 21:06 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2016-11-24 21:06 UTC (permalink / raw)
To: mrv; +Cc: netdev, jhs, xiyou.wangcong, daniel
From: Roman Mashak <mrv@mojatatu.com>
Date: Tue, 22 Nov 2016 20:57:04 -0500
> Should pass valid filter handle, not the netlink flags.
>
> Fixes: 30a391a13ab92 ("net sched filters: pass netlink message flags in event notification")
> Signed-off-by: Roman Mashak <mrv@mojatatu.com>
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-24 21:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-23 1:57 [PATCH net 1/1] net sched filters: fix filter handle ID in tfilter_notify_chain() Roman Mashak
2016-11-23 4:09 ` Cong Wang
2016-11-23 7:34 ` Daniel Borkmann
2016-11-24 21:06 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).