* [PATCH] net: ethtool: don't require CAP_NET_ADMIN for ETHTOOL_GLINKSETTINGS
@ 2016-11-24 9:55 Miroslav Lichvar
2016-11-26 1:23 ` David Miller
2016-12-25 7:44 ` Vincent Bernat
0 siblings, 2 replies; 4+ messages in thread
From: Miroslav Lichvar @ 2016-11-24 9:55 UTC (permalink / raw)
To: netdev; +Cc: David Decotigny
The ETHTOOL_GLINKSETTINGS command is deprecating the ETHTOOL_GSET
command and likewise it shouldn't require the CAP_NET_ADMIN capability.
Signed-off-by: Miroslav Lichvar <mlichvar@redhat.com>
---
net/core/ethtool.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index 9774898..047a175 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -2479,6 +2479,7 @@ int dev_ethtool(struct net *net, struct ifreq *ifr)
case ETHTOOL_GET_TS_INFO:
case ETHTOOL_GEEE:
case ETHTOOL_GTUNABLE:
+ case ETHTOOL_GLINKSETTINGS:
break;
default:
if (!ns_capable(net->user_ns, CAP_NET_ADMIN))
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: ethtool: don't require CAP_NET_ADMIN for ETHTOOL_GLINKSETTINGS
2016-11-24 9:55 [PATCH] net: ethtool: don't require CAP_NET_ADMIN for ETHTOOL_GLINKSETTINGS Miroslav Lichvar
@ 2016-11-26 1:23 ` David Miller
2016-12-25 7:44 ` Vincent Bernat
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2016-11-26 1:23 UTC (permalink / raw)
To: mlichvar; +Cc: netdev, decot
From: Miroslav Lichvar <mlichvar@redhat.com>
Date: Thu, 24 Nov 2016 10:55:06 +0100
> The ETHTOOL_GLINKSETTINGS command is deprecating the ETHTOOL_GSET
> command and likewise it shouldn't require the CAP_NET_ADMIN capability.
>
> Signed-off-by: Miroslav Lichvar <mlichvar@redhat.com>
Good catch, applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: ethtool: don't require CAP_NET_ADMIN for ETHTOOL_GLINKSETTINGS
2016-11-24 9:55 [PATCH] net: ethtool: don't require CAP_NET_ADMIN for ETHTOOL_GLINKSETTINGS Miroslav Lichvar
2016-11-26 1:23 ` David Miller
@ 2016-12-25 7:44 ` Vincent Bernat
2016-12-26 17:38 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Vincent Bernat @ 2016-12-25 7:44 UTC (permalink / raw)
To: Miroslav Lichvar; +Cc: netdev, David Decotigny
❦ 24 novembre 2016 10:55 +0100, Miroslav Lichvar <mlichvar@redhat.com> :
> The ETHTOOL_GLINKSETTINGS command is deprecating the ETHTOOL_GSET
> command and likewise it shouldn't require the CAP_NET_ADMIN
> capability.
Could this patch be pushed to stable branches too?
--
Each module should do one thing well.
- The Elements of Programming Style (Kernighan & Plauger)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net: ethtool: don't require CAP_NET_ADMIN for ETHTOOL_GLINKSETTINGS
2016-12-25 7:44 ` Vincent Bernat
@ 2016-12-26 17:38 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2016-12-26 17:38 UTC (permalink / raw)
To: bernat; +Cc: mlichvar, netdev, decot
From: Vincent Bernat <bernat@luffy.cx>
Date: Sun, 25 Dec 2016 08:44:40 +0100
> ❦ 24 novembre 2016 10:55 +0100, Miroslav Lichvar <mlichvar@redhat.com> :
>
>> The ETHTOOL_GLINKSETTINGS command is deprecating the ETHTOOL_GSET
>> command and likewise it shouldn't require the CAP_NET_ADMIN
>> capability.
>
> Could this patch be pushed to stable branches too?
Sure, queued up.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-26 17:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-24 9:55 [PATCH] net: ethtool: don't require CAP_NET_ADMIN for ETHTOOL_GLINKSETTINGS Miroslav Lichvar
2016-11-26 1:23 ` David Miller
2016-12-25 7:44 ` Vincent Bernat
2016-12-26 17:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).