From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: "Vishwanathapura,
Niranjana"
<niranjana.vishwanathapura-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "ira.weiny" <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Dennis Dalessandro
<dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [RFC 02/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) Bus driver
Date: Thu, 24 Nov 2016 09:15:45 -0700 [thread overview]
Message-ID: <20161124161545.GA20818@obsidianresearch.com> (raw)
In-Reply-To: <20161124000825.GA73280-wPcXA7LoDC+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
On Wed, Nov 23, 2016 at 04:08:25PM -0800, Vishwanathapura, Niranjana wrote:
> In order to pass the hfi function pointers to the hfi_vnic ULP, I can,
> a) Have hfi_vnic ULP define an interface API for hfi1 driver to call to
> register its callback (as you pointed). Unfortunately there will be a module
> dependency here.
> Or,
That is probably backwards
> b) Add a new member ‘struct vnic_ops’ either to the ib_device structure or
> ib_port_immutable structure. As it is hfi1 specific, only hfi1 driver will
> set it. No module dependency here.
You can add a hfi1_get_vnic_ops(struct ib_device *) and implement it
in your module..
> And will move the hfi_vnic module under
> ‘drivers/infiniband/ulp/hfi_vnic’.
I would prefer drivers/net/ethernet
This is clearly not a ULP since it doesn't use verbs.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-11-24 16:15 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 22:42 [RFC 00/10] HFI Virtual Network Interface Controller (VNIC) Vishwanathapura, Niranjana
[not found] ` <1479508938-63799-1-git-send-email-niranjana.vishwanathapura-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-11-18 22:42 ` [RFC 01/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) documentation Vishwanathapura, Niranjana
2016-11-18 22:42 ` [RFC 02/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) Bus driver Vishwanathapura, Niranjana
2016-11-19 19:04 ` Jason Gunthorpe
2016-11-21 21:30 ` Vishwanathapura, Niranjana
2016-11-21 21:39 ` Jason Gunthorpe
2016-11-21 23:26 ` Vishwanathapura, Niranjana
[not found] ` <20161121232629.GA67988-wPcXA7LoDC+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2016-11-21 23:31 ` Jason Gunthorpe
[not found] ` <20161121233118.GA31132-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-11-22 1:53 ` Vishwanathapura, Niranjana
2016-11-22 17:04 ` Jason Gunthorpe
2016-11-22 19:49 ` Vishwanathapura, Niranjana
[not found] ` <20161122194918.GA69241-wPcXA7LoDC+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2016-11-22 23:04 ` Christoph Lameter
2016-11-23 0:53 ` Vishwanathapura, Niranjana
2016-11-23 0:06 ` Andrew Lunn
[not found] ` <20161122170407.GE3956-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-11-23 0:05 ` ira.weiny
2016-11-23 0:49 ` Jason Gunthorpe
[not found] ` <20161123004932.GA13598-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-11-24 0:08 ` Vishwanathapura, Niranjana
[not found] ` <20161124000825.GA73280-wPcXA7LoDC+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2016-11-24 16:15 ` Jason Gunthorpe [this message]
[not found] ` <20161124161545.GA20818-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-11-25 2:13 ` Vishwanathapura, Niranjana
[not found] ` <20161125021350.GA74946-wPcXA7LoDC+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2016-11-25 19:05 ` Jason Gunthorpe
[not found] ` <20161125190509.GB16504-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-11-29 6:31 ` Vishwanathapura, Niranjana
[not found] ` <20161129063106.GB84990-wPcXA7LoDC+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2016-11-29 16:19 ` Jason Gunthorpe
[not found] ` <20161129161950.GB742-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-11-29 16:44 ` Hefty, Sean
2016-11-29 16:50 ` Jason Gunthorpe
[not found] ` <20161129165009.GA3167-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-12-01 7:39 ` Vishwanathapura, Niranjana
2016-11-29 6:29 ` Vishwanathapura, Niranjana
[not found] ` <20161129062938.GA84990-wPcXA7LoDC+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2016-11-29 16:21 ` Jason Gunthorpe
[not found] ` <20161129162113.GC742-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-12-01 7:41 ` Vishwanathapura, Niranjana
2016-11-18 22:42 ` [RFC 03/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) netdev driver Vishwanathapura, Niranjana
2016-11-18 22:42 ` [RFC 04/10] IB/hfi-vnic: VNIC Ethernet Management (EM) structure definitions Vishwanathapura, Niranjana
2016-11-18 22:42 ` [RFC 07/10] IB/hfi-vnic: VNIC Ethernet Management Agent (VEMA) interface Vishwanathapura, Niranjana
2016-11-18 22:42 ` [RFC 08/10] IB/hfi-vnic: VNIC Ethernet Management Agent (VEMA) driver Vishwanathapura, Niranjana
2016-11-18 22:42 ` [RFC 10/10] IB/hfi1: VNIC SDMA support Vishwanathapura, Niranjana
2016-11-18 22:42 ` [RFC 05/10] IB/hfi-vnic: VNIC statistics support Vishwanathapura, Niranjana
2016-11-18 22:42 ` [RFC 06/10] IB/hfi-vnic: VNIC MAC table support Vishwanathapura, Niranjana
2016-11-18 22:42 ` [RFC 09/10] IB/hfi1: Virtual Network Interface Controller (VNIC) support Vishwanathapura, Niranjana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124161545.GA20818@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=niranjana.vishwanathapura-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).