From: Jiri Benc <jbenc@redhat.com>
To: Amir Vadai <amir@vadai.me>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Or Gerlitz <ogerlitz@mellanox.com>,
Hadar Har-Zion <hadarh@mellanox.com>,
Roi Dayan <roid@mellanox.com>
Subject: Re: [PATCH iproute2 0/2] tc/cls_flower: Support for ip tunnel metadata set/release/classify
Date: Thu, 24 Nov 2016 16:33:55 +0100 [thread overview]
Message-ID: <20161124163355.1c4d686f@griffin> (raw)
In-Reply-To: <20161124150633.GA27727@office.localdomain>
On Thu, 24 Nov 2016 17:06:33 +0200, Amir Vadai wrote:
> So you mean to just unconditionally call skb_dst_drop() from
> act_mirred()?
That's one option. Or just leave the dst there, it shouldn't matter?
(Except for forwarding to a different tunnel but as I said, it's a
corner case and we may have a "tunnel_key unset" action for that.)
> The use case we already have that uses the release action is the
> hardware offload support, which is already in the kernel.
> It is using the "tunnel_key release" action to signal the hardware to
> strip off the ip tunnel headers.
The tunnel headers must be removed upon reception on the tunnel
interface without specifying anything, because that's how the Linux
kernel behaves currently. If this is offloaded, this behavior must be
preserved. I don't see how "tunnel_key release" might be used for
stripping the headers.
Jiri
next prev parent reply other threads:[~2016-11-24 15:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 10:20 [PATCH iproute2 0/2] tc/cls_flower: Support for ip tunnel metadata set/release/classify Amir Vadai
2016-11-21 10:20 ` [PATCH iproute2 1/2] tc/cls_flower: Classify packet in ip tunnels Amir Vadai
2016-11-21 10:20 ` [PATCH iproute2 2/2] tc/act_tunnel: Introduce ip tunnel action Amir Vadai
2016-11-21 23:50 ` Rosen, Rami
2016-11-22 7:50 ` Amir Vadai
2016-11-24 13:38 ` [PATCH iproute2 0/2] tc/cls_flower: Support for ip tunnel metadata set/release/classify Jiri Benc
2016-11-24 15:06 ` Amir Vadai
2016-11-24 15:33 ` Jiri Benc [this message]
2016-11-27 10:35 ` Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124163355.1c4d686f@griffin \
--to=jbenc@redhat.com \
--cc=amir@vadai.me \
--cc=davem@davemloft.net \
--cc=hadarh@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=roid@mellanox.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).