From: Jiri Benc <jbenc@redhat.com>
To: Jarno Rajahalme <jarno@ovn.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] openvswitch: Add a missing break statement.
Date: Thu, 24 Nov 2016 16:55:33 +0100 [thread overview]
Message-ID: <20161124165533.7eaf4b01@griffin> (raw)
In-Reply-To: <1479874174-75329-1-git-send-email-jarno@ovn.org>
On Tue, 22 Nov 2016 20:09:33 -0800, Jarno Rajahalme wrote:
> Add a break statement to prevent fall-through from
> OVS_KEY_ATTR_ETHERNET to OVS_KEY_ATTR_TUNNEL. Without the break
> actions setting ethernet addresses fail to validate with log messages
> complaining about invalid tunnel attributes.
>
> Fixes: 0a6410fbde ("openvswitch: netlink: support L3 packets")
> Signed-off-by: Jarno Rajahalme <jarno@ovn.org>
Acked-by: Jiri Benc <jbenc@redhat.com>
It's a good practice to CC the one who messed up :-) Please do that
next time.
Thanks for noticing the bug and fixing it.
Jiri
prev parent reply other threads:[~2016-11-24 15:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 4:09 [PATCH net-next 1/2] openvswitch: Add a missing break statement Jarno Rajahalme
2016-11-23 4:09 ` [PATCH net-next 2/2] openvswitch: Fix skb->protocol for vlan frames Jarno Rajahalme
2016-11-24 16:10 ` Jiri Benc
2016-11-28 22:29 ` Jarno Rajahalme
2016-11-28 22:42 ` Jiri Benc
2016-11-28 22:58 ` Jarno Rajahalme
2016-11-23 19:23 ` [PATCH net-next 1/2] openvswitch: Add a missing break statement Pravin Shelar
2016-11-24 15:55 ` Jiri Benc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124165533.7eaf4b01@griffin \
--to=jbenc@redhat.com \
--cc=jarno@ovn.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).