* [patch] fsl/fman: fix a leak in tgec_free()
@ 2016-11-24 11:20 Dan Carpenter
2016-11-24 12:01 ` Madalin-Cristian Bucur
2016-11-26 1:30 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2016-11-24 11:20 UTC (permalink / raw)
To: Madalin Bucur, Igal Liberman; +Cc: netdev, kernel-janitors
We set "tgec->cfg" to NULL before passing it to kfree(). There is no
need to set it to NULL at all. Let's just delete it.
Fixes: 57ba4c9b56d8 ("fsl/fman: Add FMan MAC support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I haven't tested this. It occurs to me that this code might be
something to paper over a use after free bug by changing it to a leak
instead.
It applies to net-master.
diff --git a/drivers/net/ethernet/freescale/fman/fman_tgec.c b/drivers/net/ethernet/freescale/fman/fman_tgec.c
index efabb04..4b0f3a5 100644
--- a/drivers/net/ethernet/freescale/fman/fman_tgec.c
+++ b/drivers/net/ethernet/freescale/fman/fman_tgec.c
@@ -722,9 +722,6 @@ int tgec_free(struct fman_mac *tgec)
{
free_init_resources(tgec);
- if (tgec->cfg)
- tgec->cfg = NULL;
-
kfree(tgec->cfg);
kfree(tgec);
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [patch] fsl/fman: fix a leak in tgec_free()
2016-11-24 11:20 [patch] fsl/fman: fix a leak in tgec_free() Dan Carpenter
@ 2016-11-24 12:01 ` Madalin-Cristian Bucur
2016-11-26 1:30 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Madalin-Cristian Bucur @ 2016-11-24 12:01 UTC (permalink / raw)
To: Dan Carpenter; +Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Thursday, November 24, 2016 1:21 PM
> To: Madalin-Cristian Bucur <madalin.bucur@nxp.com>; Igal Liberman
> <igal.liberman@freescale.com>
> Cc: netdev@vger.kernel.org; kernel-janitors@vger.kernel.org
> Subject: [patch] fsl/fman: fix a leak in tgec_free()
>
> We set "tgec->cfg" to NULL before passing it to kfree(). There is no
> need to set it to NULL at all. Let's just delete it.
Agree, thanks.
> Fixes: 57ba4c9b56d8 ("fsl/fman: Add FMan MAC support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> I haven't tested this. It occurs to me that this code might be
> something to paper over a use after free bug by changing it to a leak
> instead.
>
> It applies to net-master.
>
> diff --git a/drivers/net/ethernet/freescale/fman/fman_tgec.c
> b/drivers/net/ethernet/freescale/fman/fman_tgec.c
> index efabb04..4b0f3a5 100644
> --- a/drivers/net/ethernet/freescale/fman/fman_tgec.c
> +++ b/drivers/net/ethernet/freescale/fman/fman_tgec.c
> @@ -722,9 +722,6 @@ int tgec_free(struct fman_mac *tgec)
> {
> free_init_resources(tgec);
>
> - if (tgec->cfg)
> - tgec->cfg = NULL;
> -
> kfree(tgec->cfg);
> kfree(tgec);
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] fsl/fman: fix a leak in tgec_free()
2016-11-24 11:20 [patch] fsl/fman: fix a leak in tgec_free() Dan Carpenter
2016-11-24 12:01 ` Madalin-Cristian Bucur
@ 2016-11-26 1:30 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-11-26 1:30 UTC (permalink / raw)
To: dan.carpenter; +Cc: madalin.bucur, igal.liberman, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 24 Nov 2016 14:20:43 +0300
> We set "tgec->cfg" to NULL before passing it to kfree(). There is no
> need to set it to NULL at all. Let's just delete it.
>
> Fixes: 57ba4c9b56d8 ("fsl/fman: Add FMan MAC support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-26 1:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-24 11:20 [patch] fsl/fman: fix a leak in tgec_free() Dan Carpenter
2016-11-24 12:01 ` Madalin-Cristian Bucur
2016-11-26 1:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).