netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Eli Cooper <elicooper@gmx.com>
Cc: netdev@vger.kernel.org
Subject: Re: Large performance regression with 6in4 tunnel (sit)
Date: Sun, 27 Nov 2016 13:02:29 +1100	[thread overview]
Message-ID: <20161127130229.4c88cc2c@canb.auug.org.au> (raw)
In-Reply-To: <20161127115441.7654a4e0@canb.auug.org.au>

Hi Eli,

On Sun, 27 Nov 2016 11:54:41 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Fri, 25 Nov 2016 14:05:04 +0800 Eli Cooper <elicooper@gmx.com> wrote:
> >
> > I think this is similar to the bug I fixed in commit ae148b085876
> > ("ip6_tunnel: Update skb->protocol to ETH_P_IPV6 in ip6_tnl_xmit()").
> > 
> > I can reproduce a similar problem by applying xfrm to sit traffic.
> > TSO/GSO packets are dropped when IPSec is enabled, and IPv6 throughput
> > drops to 10s of Kbps. I am not sure if this is the same issue you
> > experienced, but I wrote a patch that fixed at least the issue I had.
> > 
> > Could you test the patch I sent to the mailing list just now?  
> 
> Thanks for the patch!
> 
> Its a bit tricky to test since the problem only occurs in a production
> machine (I tried reproducing in a VM, but the problem did not occur),
> but I will try to just rebuild the sit module and see if I can insert
> the modified one.

OK, I tried your patch and unfortunately, it doesn't seem to have
worked ... I still get the large packets dropped and resent smaller.

-- 
Cheers,
Stephen Rothwell

  reply	other threads:[~2016-11-27  2:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-25  1:09 Large performance regression with 6in4 tunnel (sit) Stephen Rothwell
2016-11-25  2:18 ` Eli Cooper
2016-11-25  2:45   ` Stephen Rothwell
2016-11-25  3:01     ` Eric Dumazet
2016-11-25  3:09       ` Stephen Rothwell
2016-11-25  3:54         ` Eric Dumazet
2016-11-25  6:12           ` Stephen Rothwell
2016-11-25  4:06     ` Sven-Haegar Koch
2016-11-27  3:23       ` Stephen Rothwell
2016-11-28 17:54         ` Lance Richardson
2016-11-28 19:49           ` Lance Richardson
2016-11-28 21:32         ` Alexander Duyck
2016-11-28 22:38           ` Stephen Rothwell
2016-11-25  6:05     ` Eli Cooper
2016-11-27  0:54       ` Stephen Rothwell
2016-11-27  2:02         ` Stephen Rothwell [this message]
2016-11-27 16:22           ` Eli Cooper
2016-11-25  2:30 ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161127130229.4c88cc2c@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=elicooper@gmx.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).