From: Andrew Lunn <andrew@lunn.ch>
To: "Andreas Färber" <afaerber@suse.de>
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Uwe Kleine-König" <uwe@kleine-koenig.org>,
"Michal Hrusecki" <Michal.Hrusecky@nic.cz>,
"Tomas Hlavacek" <tomas.hlavacek@nic.cz>,
"Bed??icha Ko??atu" <bedrich.kosata@nic.cz>,
"Vivien Didelot" <vivien.didelot@savoirfairelinux.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count
Date: Sun, 27 Nov 2016 22:22:56 +0100 [thread overview]
Message-ID: <20161127212256.GC13318@lunn.ch> (raw)
In-Reply-To: <1480279424-7830-1-git-send-email-afaerber@suse.de>
On Sun, Nov 27, 2016 at 09:43:44PM +0100, Andreas Färber wrote:
> mv88e6xxx_g1_irq_setup() sets up chip->g1_irq.nirqs interrupt mappings,
> so free the same amount. This will be 8 or 9 in practice, less than 16.
Hi Andreas
The patch is correct, but please read
Documentation/networking/netdev-FAQ.txt
and then resubmit the patch.
Andrew
>
> Fixes: dc30c35be720 ("net: dsa: mv88e6xxx: Implement interrupt support.")
> Cc: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
> index 98302358ceb9..95b9efb33ec7 100644
> --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -421,7 +421,7 @@ static void mv88e6xxx_g1_irq_free(struct mv88e6xxx_chip *chip)
>
> free_irq(chip->irq, chip);
>
> - for (irq = 0; irq < 16; irq++) {
> + for (irq = 0; irq < chip->g1_irq.nirqs; irq++) {
> virq = irq_find_mapping(chip->g1_irq.domain, irq);
> irq_dispose_mapping(virq);
> }
> --
> 2.6.6
>
next prev parent reply other threads:[~2016-11-27 21:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-27 20:43 [PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count Andreas Färber
2016-11-27 21:22 ` Andrew Lunn [this message]
2016-11-27 21:32 ` Andreas Färber
2016-11-27 21:39 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161127212256.GC13318@lunn.ch \
--to=andrew@lunn.ch \
--cc=Michal.Hrusecky@nic.cz \
--cc=afaerber@suse.de \
--cc=bedrich.kosata@nic.cz \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tomas.hlavacek@nic.cz \
--cc=uwe@kleine-koenig.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).