From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] virtio-net: enable multiqueue by default Date: Mon, 28 Nov 2016 13:18:05 -0500 (EST) Message-ID: <20161128.131805.1395686082038152344.davem@davemloft.net> References: <1480048646-17536-1-git-send-email-jasowang@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: nhorman@redhat.com, jeder@redhat.com, hannes@redhat.com, netdev@vger.kernel.org, mst@redhat.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, myllynen@redhat.com, maxime.coquelin@redhat.com To: jasowang@redhat.com Return-path: In-Reply-To: <1480048646-17536-1-git-send-email-jasowang@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org From: Jason Wang Date: Fri, 25 Nov 2016 12:37:26 +0800 > We use single queue even if multiqueue is enabled and let admin to > enable it through ethtool later. This is used to avoid possible > regression (small packet TCP stream transmission). But looks like an > overkill since: > > - single queue user can disable multiqueue when launching qemu > - brings extra troubles for the management since it needs extra admin > tool in guest to enable multiqueue > - multiqueue performs much better than single queue in most of the > cases > > So this patch enables multiqueue by default: if #queues is less than or > equal to #vcpu, enable as much as queue pairs; if #queues is greater > than #vcpu, enable #vcpu queue pairs. > > Cc: Hannes Frederic Sowa > Cc: Michael S. Tsirkin > Cc: Neil Horman > Cc: Jeremy Eder > Cc: Marko Myllynen > Cc: Maxime Coquelin > Signed-off-by: Jason Wang Applied, thanks Jason.