* [PATCH] geneve: fix ip_hdr_len reserved for geneve6 tunnel.
@ 2016-11-28 5:26 Haishuang Yan
2016-11-28 5:57 ` Pravin Shelar
2016-11-28 21:15 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Haishuang Yan @ 2016-11-28 5:26 UTC (permalink / raw)
To: David S. Miller, Hannes Frederic Sowa, Alexander Duyck,
Pravin B Shelar, Jiri Benc
Cc: netdev, linux-kernel, Haishuang Yan
It shold reserved sizeof(ipv6hdr) for geneve in ipv6 tunnel.
Fixes: c3ef5aa5e5 ('geneve: Merge ipv4 and ipv6 geneve_build_skb()')
Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
---
drivers/net/geneve.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
index 7b80e28..45301cb 100644
--- a/drivers/net/geneve.c
+++ b/drivers/net/geneve.c
@@ -852,7 +852,7 @@ static int geneve6_xmit_skb(struct sk_buff *skb, struct net_device *dev,
ip_hdr(skb), skb);
ttl = key->ttl ? : ip6_dst_hoplimit(dst);
}
- err = geneve_build_skb(dst, skb, info, xnet, sizeof(struct iphdr));
+ err = geneve_build_skb(dst, skb, info, xnet, sizeof(struct ipv6hdr));
if (unlikely(err))
return err;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] geneve: fix ip_hdr_len reserved for geneve6 tunnel.
2016-11-28 5:26 [PATCH] geneve: fix ip_hdr_len reserved for geneve6 tunnel Haishuang Yan
@ 2016-11-28 5:57 ` Pravin Shelar
2016-11-28 21:15 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Pravin Shelar @ 2016-11-28 5:57 UTC (permalink / raw)
To: Haishuang Yan
Cc: David S. Miller, Hannes Frederic Sowa, Alexander Duyck,
Pravin B Shelar, Jiri Benc, Linux Kernel Network Developers,
linux-kernel
On Sun, Nov 27, 2016 at 9:26 PM, Haishuang Yan
<yanhaishuang@cmss.chinamobile.com> wrote:
> It shold reserved sizeof(ipv6hdr) for geneve in ipv6 tunnel.
>
> Fixes: c3ef5aa5e5 ('geneve: Merge ipv4 and ipv6 geneve_build_skb()')
>
> Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Thanks for fix.
Acked-by: Pravin B Shelar <pshelar@ovn.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] geneve: fix ip_hdr_len reserved for geneve6 tunnel.
2016-11-28 5:26 [PATCH] geneve: fix ip_hdr_len reserved for geneve6 tunnel Haishuang Yan
2016-11-28 5:57 ` Pravin Shelar
@ 2016-11-28 21:15 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-11-28 21:15 UTC (permalink / raw)
To: yanhaishuang; +Cc: hannes, aduyck, pshelar, jbenc, netdev, linux-kernel
From: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Date: Mon, 28 Nov 2016 13:26:58 +0800
> It shold reserved sizeof(ipv6hdr) for geneve in ipv6 tunnel.
>
> Fixes: c3ef5aa5e5 ('geneve: Merge ipv4 and ipv6 geneve_build_skb()')
>
> Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-28 21:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-28 5:26 [PATCH] geneve: fix ip_hdr_len reserved for geneve6 tunnel Haishuang Yan
2016-11-28 5:57 ` Pravin Shelar
2016-11-28 21:15 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).