From: Florian Westphal <fw@strlen.de>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: Florian Westphal <fw@strlen.de>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
netfilter-devel@vger.kernel.org
Subject: Re: net/sctp: vmalloc allocation failure in sctp_setsockopt/xt_alloc_table_info
Date: Mon, 28 Nov 2016 19:09:25 +0100 [thread overview]
Message-ID: <20161128180925.GF28510@breakpoint.cc> (raw)
In-Reply-To: <20161128175626.GD29839@hmsreliant.think-freely.org>
Neil Horman <nhorman@tuxdriver.com> wrote:
[ trimming CCs ]
> On Mon, Nov 28, 2016 at 06:47:10PM +0100, Florian Westphal wrote:
> > Neil Horman <nhorman@tuxdriver.com> wrote:
> > > I'm not sure I agree with that. Generally speaking it seems like the right
> > > thing to do, if you want to avoid filling logs with warnings, but this is the
> > > sort of error that is going to be accompanied by severe service interruption.
> > > I'd rather see a reason behind that in the logs, than just have it occur
> > > silently.
> >
> > Its not silent -- the setsockopt call will fail and userspace should
> > display an error.
> >
> Thats not true. If the OOM succedes in freeing enough memory to fulfill the
> request the setsockopt may complete without error, you're just left with a
> killed process...somewhere. Thats seems a bit dodgy to me
We should prevent OOM killer from running in first place (GFP_NORETRY should work).
next prev parent reply other threads:[~2016-11-28 18:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 13:00 net/sctp: vmalloc allocation failure in sctp_setsockopt/xt_alloc_table_info Andrey Konovalov
2016-11-28 14:13 ` Neil Horman
2016-11-28 14:33 ` Andrey Konovalov
2016-11-28 14:39 ` Neil Horman
2016-11-28 15:13 ` Marcelo Ricardo Leitner
2016-11-28 17:46 ` Neil Horman
2016-11-28 17:47 ` Florian Westphal
2016-11-28 17:56 ` Neil Horman
2016-11-28 18:09 ` Florian Westphal [this message]
2016-11-28 18:18 ` Marcelo Ricardo Leitner
2016-11-30 19:21 ` Marcelo Ricardo Leitner
2016-11-30 19:42 ` [PATCH] netfilter: avoid warn and OOM on vmalloc call Marcelo Ricardo Leitner
2016-12-01 9:42 ` Andrey Konovalov
2016-12-01 19:08 ` Marcelo Ricardo Leitner
2016-11-28 18:26 ` net/sctp: vmalloc allocation failure in sctp_setsockopt/xt_alloc_table_info Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128180925.GF28510@breakpoint.cc \
--to=fw@strlen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).