From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: andreyknvl@google.com, gerrit@erg.abdn.ac.uk,
dccp@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, dvyukov@google.com, kcc@google.com,
edumazet@google.com, syzkaller@googlegroups.com
Subject: Re: [PATCH net] net/dccp: fix use-after-free in dccp_invalid_packet
Date: Tue, 29 Nov 2016 20:38:01 -0500 (EST) [thread overview]
Message-ID: <20161129.203801.926114791600466509.davem@davemloft.net> (raw)
In-Reply-To: <1480343209.18162.50.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 28 Nov 2016 06:26:49 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> pskb_may_pull() can reallocate skb->head, we need to reload dh pointer
> in dccp_invalid_packet() or risk use after free.
>
> Bug found by Andrey Konovalov using syzkaller.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Andrey Konovalov <andreyknvl@google.com>
Applied and queued up for -stable, thanks Eric.
prev parent reply other threads:[~2016-11-30 1:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 13:22 net/dccp: use-after-free in dccp_invalid_packet Andrey Konovalov
2016-11-28 14:26 ` [PATCH net] net/dccp: fix " Eric Dumazet
2016-11-28 14:40 ` Arnaldo Carvalho de Melo
2016-11-28 14:47 ` Eric Dumazet
2016-11-28 15:05 ` Arnaldo Carvalho de Melo
2016-11-28 15:20 ` Eric Dumazet
2016-11-28 15:36 ` Arnaldo Carvalho de Melo
2016-11-30 1:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129.203801.926114791600466509.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andreyknvl@google.com \
--cc=dccp@vger.kernel.org \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=gerrit@erg.abdn.ac.uk \
--cc=kcc@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).