From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
bcm-kernel-feedback-list@broadcom.com,
allan.nielsen@microsemi.com, raju.lakkaraju@microsemi.com
Subject: Re: [PATCH net-next v2 2/2] net: phy: bcm7xxx: Plug in support for reading PHY error counters
Date: Tue, 29 Nov 2016 03:50:18 +0100 [thread overview]
Message-ID: <20161129025018.GA28968@lunn.ch> (raw)
In-Reply-To: <20161129010457.17438-3-f.fainelli@gmail.com>
> +struct bcm7xxx_phy_priv {
> + u64 *stats;
> +};
> +static int bcm7xxx_28nm_probe(struct phy_device *phydev)
> +{
> + struct bcm7xxx_phy_priv *priv;
> +
> + priv = devm_kzalloc(&phydev->mdio.dev, sizeof(*priv), GFP_KERNEL);
> + if (!priv)
> + return -ENOMEM;
> +
> + phydev->priv = priv;
> +
> + priv->stats = devm_kzalloc(&phydev->mdio.dev,
> + bcm_phy_get_sset_count(phydev), GFP_KERNEL);
Hi Florian
Should there be a * sizeof(u64) in there?
Andrew
next prev parent reply other threads:[~2016-11-29 2:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 1:04 [PATCH net-next v2 0/2] net: phy: broadcom: Support for PHY counters Florian Fainelli
2016-11-29 1:04 ` [PATCH net-next v2 1/2] net: phy: broadcom: Add support code for reading " Florian Fainelli
2016-11-29 1:04 ` [PATCH net-next v2 2/2] net: phy: bcm7xxx: Plug in support for reading PHY error counters Florian Fainelli
2016-11-29 2:50 ` Andrew Lunn [this message]
2016-11-29 3:20 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129025018.GA28968@lunn.ch \
--to=andrew@lunn.ch \
--cc=allan.nielsen@microsemi.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=raju.lakkaraju@microsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).