netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: Sven-Haegar Koch <haegar@sdinet.de>,
	Eli Cooper <elicooper@gmx.com>, Netdev <netdev@vger.kernel.org>,
	Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: Large performance regression with 6in4 tunnel (sit)
Date: Tue, 29 Nov 2016 09:38:09 +1100	[thread overview]
Message-ID: <20161129093809.45bae6d1@canb.auug.org.au> (raw)
In-Reply-To: <CAKgT0Ue3f0hUnCvwBupqmhBE_bbxZUO7ODXsz2cbHrPu5gAqyA@mail.gmail.com>

Hi Alex,

On Mon, 28 Nov 2016 13:32:21 -0800 Alexander Duyck <alexander.duyck@gmail.com> wrote:
>
> So I think I have this root caused.  The problem seems to be the fact
> that I chose to use lco_csum when trying to cancel out the inner IP
> header from the checksum and it turns out that the transport offset is
> never updated in the case of these tunnels.
> 
> For now a workaround is to just set tx-gso-partial to off on the
> interface the tunnel is running over and you should be able to pass
> traffic without any issues.

OK, so that works (even with gso and tso set to "on" on the sit
interface).  Thanks.

> I have a patch for igb/igbvf that should be out in the next hour or so
> which should address it.

That will be a bit harder to test, but I will see what I can do.

-- 
Cheers,
Stephen Rothwell

  reply	other threads:[~2016-11-28 22:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-25  1:09 Large performance regression with 6in4 tunnel (sit) Stephen Rothwell
2016-11-25  2:18 ` Eli Cooper
2016-11-25  2:45   ` Stephen Rothwell
2016-11-25  3:01     ` Eric Dumazet
2016-11-25  3:09       ` Stephen Rothwell
2016-11-25  3:54         ` Eric Dumazet
2016-11-25  6:12           ` Stephen Rothwell
2016-11-25  4:06     ` Sven-Haegar Koch
2016-11-27  3:23       ` Stephen Rothwell
2016-11-28 17:54         ` Lance Richardson
2016-11-28 19:49           ` Lance Richardson
2016-11-28 21:32         ` Alexander Duyck
2016-11-28 22:38           ` Stephen Rothwell [this message]
2016-11-25  6:05     ` Eli Cooper
2016-11-27  0:54       ` Stephen Rothwell
2016-11-27  2:02         ` Stephen Rothwell
2016-11-27 16:22           ` Eli Cooper
2016-11-25  2:30 ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161129093809.45bae6d1@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=alexander.duyck@gmail.com \
    --cc=elicooper@gmx.com \
    --cc=eric.dumazet@gmail.com \
    --cc=haegar@sdinet.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).