From: Stephen Hemminger <stephen@networkplumber.org>
To: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Cc: netdev@vger.kernel.org
Subject: Re: [iproute2] iproute2: fix the link group name getting error
Date: Tue, 29 Nov 2016 12:49:17 -0800 [thread overview]
Message-ID: <20161129124917.498ceecc@samsung9> (raw)
In-Reply-To: <1479431573-2910-1-git-send-email-zhangshengju@cmss.chinamobile.com>
On Fri, 18 Nov 2016 09:12:53 +0800
Zhang Shengju <zhangshengju@cmss.chinamobile.com> wrote:
> In the situation where more than one entry live in the same hash bucket,
> loop to get the correct one.
>
> Before:
> $ cat /etc/iproute2/group
> 0 default
> 256 test
>
> $ sudo ip link set group test dummy1
>
> $ ip link show type dummy
> 11: dummy0: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group 0 qlen 1000
> link/ether 4e:3b:d3:6c:f0:e6 brd ff:ff:ff:ff:ff:ff
> 12: dummy1: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group test qlen 1000
> link/ether d6:9c:a4:1f:e7:e5 brd ff:ff:ff:ff:ff:ff
>
> After:
> $ ip link show type dummy
> 11: dummy0: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
> link/ether 4e:3b:d3:6c:f0:e6 brd ff:ff:ff:ff:ff:ff
> 12: dummy1: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group test qlen 1000
> link/ether d6:9c:a4:1f:e7:e5 brd ff:ff:ff:ff:ff:ff
>
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Applied, and queued for next push.
prev parent reply other threads:[~2016-11-29 20:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 1:12 [iproute2] iproute2: fix the link group name getting error Zhang Shengju
2016-11-29 20:49 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129124917.498ceecc@samsung9 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=zhangshengju@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox