From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: netdev@vger.kernel.org, Nicolai Stange <nicstange@gmail.com>,
Christian Lamparter <chunkeey@gmail.com>
Subject: Re: [PATCH] debugfs: improve formatting of debugfs_real_fops()
Date: Tue, 29 Nov 2016 21:27:57 +0100 [thread overview]
Message-ID: <20161129202756.GA14599@kroah.com> (raw)
In-Reply-To: <CAJpBn1xRuJYfDewZhOs4GvGpXKxndL+ux5c69ACA4Y4RS+X8kA@mail.gmail.com>
On Tue, Nov 29, 2016 at 12:11:37PM -0800, Jakub Kicinski wrote:
> On Tue, Nov 29, 2016 at 11:58 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Thu, Nov 10, 2016 at 05:23:49PM +0000, Jakub Kicinski wrote:
> >> Type of debugfs_real_fops() is longer than parameters and
> >> the name, so there is no way to break the declaration nicely.
> >> We have to go over 80 characters.
> >>
> >> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> >> ---
> >> include/linux/debugfs.h | 3 +--
> >> 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > Doesn't apply to my tree, what did you make this against?
>
> net-next, sorry, it
>
> Fixes: 68f929ff2654 ("debugfs: constify argument to debugfs_real_fops()")
>
> I think that change still haven't propagated out of Dave's tree. Dave
> didn't take my fix up patch, though, so my plan was to resend it to
> you during the merge window? Would that make sense?
Sure, that will work.
thanks,
greg k-h
prev parent reply other threads:[~2016-11-29 20:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 17:23 [PATCH] debugfs: improve formatting of debugfs_real_fops() Jakub Kicinski
2016-11-10 17:51 ` Greg Kroah-Hartman
2016-11-16 0:47 ` [PATCH net-next] " Jakub Kicinski
2016-11-29 19:58 ` [PATCH] " Greg Kroah-Hartman
2016-11-29 20:11 ` Jakub Kicinski
2016-11-29 20:27 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129202756.GA14599@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chunkeey@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=nicstange@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).