From: David Miller <davem@davemloft.net>
To: alexander.h.duyck@intel.com
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
sfr@canb.auug.org.au, jeffrey.t.kirsher@intel.com
Subject: Re: [net PATCH 0/2] Don't use lco_csum to compute IPv4 checksum
Date: Wed, 30 Nov 2016 09:47:46 -0500 (EST) [thread overview]
Message-ID: <20161130.094746.724735454244491985.davem@davemloft.net> (raw)
In-Reply-To: <20161128153927.15466.99193.stgit@ahduyck-blue-test.jf.intel.com>
From: Alexander Duyck <alexander.h.duyck@intel.com>
Date: Mon, 28 Nov 2016 10:42:18 -0500
> When I implemented the GSO partial support in the Intel drivers I was using
> lco_csum to compute the checksum that we needed to plug into the IPv4
> checksum field in order to cancel out the data that was not a part of the
> IPv4 header. However this didn't take into account that the transport
> offset might be pointing to the inner transport header.
>
> Instead of using lco_csum I have just coded around it so that we can use
> the outer IP header plus the IP header length to determine where we need to
> start our checksum and then just call csum_partial ourselves.
>
> This should fix the SIT issue reported on igb interfaces as well as simliar
> issues that would pop up on other Intel NICs.
Jeff, are you going to send me a pull request with this stuff or would
you be OK with my applying these directly to 'net'?
Thanks.
next prev parent reply other threads:[~2016-11-30 14:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 15:42 [net PATCH 0/2] Don't use lco_csum to compute IPv4 checksum Alexander Duyck
2016-11-28 15:42 ` [net PATCH 1/2] igb/igbvf: " Alexander Duyck
2016-11-28 15:42 ` [net PATCH 2/2] ixgbe/ixgbevf: " Alexander Duyck
2016-11-28 22:26 ` [net PATCH 0/2] " Jeff Kirsher
2016-11-28 23:43 ` Stephen Rothwell
2016-11-29 9:07 ` Stephen Rothwell
2017-01-11 23:19 ` Stephen Rothwell
2016-11-30 14:47 ` David Miller [this message]
2016-11-30 21:15 ` Jeff Kirsher
2016-12-01 20:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161130.094746.724735454244491985.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).