From: David Miller <davem@davemloft.net>
To: tklauser@distanz.ch
Cc: dougmill@linux.vnet.ibm.com, netdev@vger.kernel.org
Subject: Re: [PATCH] ehea: Remove unnecessary memset of stats in netdev private data
Date: Wed, 30 Nov 2016 14:26:45 -0500 (EST) [thread overview]
Message-ID: <20161130.142645.1470335853211330441.davem@davemloft.net> (raw)
In-Reply-To: <20161129133507.5008-1-tklauser@distanz.ch>
From: Tobias Klauser <tklauser@distanz.ch>
Date: Tue, 29 Nov 2016 14:35:07 +0100
> The memory for netdev private data is allocated using kzalloc/vzalloc in
> alloc_netdev_mqs, thus there is no need to zero the stats portion of it
> again in the driver's probe function.
>
> In any case, the size for the memset is wrong as the stats member is of
> type rtnl_link_stats64, not net_device_stats.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied, thanks.
prev parent reply other threads:[~2016-11-30 19:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 13:35 [PATCH] ehea: Remove unnecessary memset of stats in netdev private data Tobias Klauser
2016-11-30 19:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161130.142645.1470335853211330441.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dougmill@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox