From: David Miller <davem@davemloft.net>
To: lorenzo@google.com
Cc: netdev@vger.kernel.org, erezsh@dev.mellanox.co.il
Subject: Re: [PATCH] net: ipv4: Don't crash if passing a null sk to ip_rt_update_pmtu.
Date: Wed, 30 Nov 2016 14:54:19 -0500 (EST) [thread overview]
Message-ID: <20161130.145419.801141163874925780.davem@davemloft.net> (raw)
In-Reply-To: <1480442207-43618-1-git-send-email-lorenzo@google.com>
From: Lorenzo Colitti <lorenzo@google.com>
Date: Wed, 30 Nov 2016 02:56:47 +0900
> Commit e2d118a1cb5e ("net: inet: Support UID-based routing in IP
> protocols.") made __build_flow_key call sock_net(sk) to determine
> the network namespace of the passed-in socket. This crashes if sk
> is NULL.
>
> Fix this by getting the network namespace from the skb instead.
>
> Reported-by: Erez Shitrit <erezsh@dev.mellanox.co.il>
> Signed-off-by: Lorenzo Colitti <lorenzo@google.com>
Applied, thanks.
prev parent reply other threads:[~2016-11-30 19:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 17:56 [PATCH] net: ipv4: Don't crash if passing a null sk to ip_rt_update_pmtu Lorenzo Colitti
2016-11-30 16:46 ` Lorenzo Colitti
2016-11-30 19:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161130.145419.801141163874925780.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=erezsh@dev.mellanox.co.il \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).