* [PATCH] sh_eth: add missing checks for status bits
@ 2016-11-30 20:01 Chris Brandt
2016-12-01 8:52 ` Simon Horman
2016-12-01 10:24 ` Sergei Shtylyov
0 siblings, 2 replies; 5+ messages in thread
From: Chris Brandt @ 2016-11-30 20:01 UTC (permalink / raw)
To: David Miller
Cc: Simon Horman, Geert Uytterhoeven, netdev, linux-renesas-soc,
Chris Brandt
When streaming a lot of data and the RZ can't keep up, some status bits
will get set that are not being checked or cleared which cause the
following messages and the Ethernet driver to stop working. This
patch fixes that issue.
irq 21: nobody cared (try booting with the "irqpoll" option)
handlers:
[<c036b71c>] sh_eth_interrupt
Disabling IRQ #21
Fixes: db893473d313a4ad ("sh_eth: Add support for r7s72100")
Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
---
drivers/net/ethernet/renesas/sh_eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
index 05b0dc5..079f10e 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -523,7 +523,7 @@ static struct sh_eth_cpu_data r7s72100_data = {
.tx_check = EESR_TC1 | EESR_FTC,
.eesr_err_check = EESR_TWB1 | EESR_TWB | EESR_TABT | EESR_RABT |
EESR_RFE | EESR_RDE | EESR_RFRMER | EESR_TFE |
- EESR_TDE | EESR_ECI,
+ EESR_TDE | EESR_ECI | EESR_TUC | EESR_ROC,
.fdr_value = 0x0000070f,
.no_psr = 1,
--
2.10.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] sh_eth: add missing checks for status bits
2016-11-30 20:01 [PATCH] sh_eth: add missing checks for status bits Chris Brandt
@ 2016-12-01 8:52 ` Simon Horman
2016-12-01 10:12 ` Sergei Shtylyov
2016-12-01 10:24 ` Sergei Shtylyov
1 sibling, 1 reply; 5+ messages in thread
From: Simon Horman @ 2016-12-01 8:52 UTC (permalink / raw)
To: Chris Brandt; +Cc: David Miller, Geert Uytterhoeven, netdev, linux-renesas-soc
On Wed, Nov 30, 2016 at 03:01:48PM -0500, Chris Brandt wrote:
> When streaming a lot of data and the RZ can't keep up, some status bits
> will get set that are not being checked or cleared which cause the
> following messages and the Ethernet driver to stop working. This
> patch fixes that issue.
>
> irq 21: nobody cared (try booting with the "irqpoll" option)
> handlers:
> [<c036b71c>] sh_eth_interrupt
> Disabling IRQ #21
>
> Fixes: db893473d313a4ad ("sh_eth: Add support for r7s72100")
> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
Hi Chris,
I am wondering if the EESR_FRC but should also be checked.
> ---
> drivers/net/ethernet/renesas/sh_eth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index 05b0dc5..079f10e 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -523,7 +523,7 @@ static struct sh_eth_cpu_data r7s72100_data = {
> .tx_check = EESR_TC1 | EESR_FTC,
> .eesr_err_check = EESR_TWB1 | EESR_TWB | EESR_TABT | EESR_RABT |
> EESR_RFE | EESR_RDE | EESR_RFRMER | EESR_TFE |
> - EESR_TDE | EESR_ECI,
> + EESR_TDE | EESR_ECI | EESR_TUC | EESR_ROC,
> .fdr_value = 0x0000070f,
>
> .no_psr = 1,
> --
> 2.10.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] sh_eth: add missing checks for status bits
2016-12-01 8:52 ` Simon Horman
@ 2016-12-01 10:12 ` Sergei Shtylyov
0 siblings, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2016-12-01 10:12 UTC (permalink / raw)
To: Simon Horman, Chris Brandt
Cc: David Miller, Geert Uytterhoeven, netdev, linux-renesas-soc
Hello!
On 12/1/2016 11:52 AM, Simon Horman wrote:
>> When streaming a lot of data and the RZ can't keep up, some status bits
>> will get set that are not being checked or cleared which cause the
>> following messages and the Ethernet driver to stop working. This
>> patch fixes that issue.
>>
>> irq 21: nobody cared (try booting with the "irqpoll" option)
>> handlers:
>> [<c036b71c>] sh_eth_interrupt
>> Disabling IRQ #21
>>
>> Fixes: db893473d313a4ad ("sh_eth: Add support for r7s72100")
>> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
>
> Hi Chris,
>
> I am wondering if the EESR_FRC but should also be checked.
EESR.FRC is not an error bit and it's part of EESR_RX_CHECK already.
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sh_eth: add missing checks for status bits
2016-11-30 20:01 [PATCH] sh_eth: add missing checks for status bits Chris Brandt
2016-12-01 8:52 ` Simon Horman
@ 2016-12-01 10:24 ` Sergei Shtylyov
2016-12-01 13:13 ` Chris Brandt
1 sibling, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2016-12-01 10:24 UTC (permalink / raw)
To: Chris Brandt, David Miller
Cc: Simon Horman, Geert Uytterhoeven, netdev, linux-renesas-soc
Hello!
Please always CC me on the sh_eth/ravb driver patches as directed by
scripts/get_maintainer.pl.
On 11/30/2016 11:01 PM, Chris Brandt wrote:
> When streaming a lot of data and the RZ can't keep up, some status bits
> will get set that are not being checked or cleared which cause the
> following messages and the Ethernet driver to stop working. This
> patch fixes that issue.
Perhaps we should just clear the correspoding bits in EESIPR instead? They
are not set for any other SoC...
> irq 21: nobody cared (try booting with the "irqpoll" option)
> handlers:
> [<c036b71c>] sh_eth_interrupt
> Disabling IRQ #21
>
> Fixes: db893473d313a4ad ("sh_eth: Add support for r7s72100")
> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [PATCH] sh_eth: add missing checks for status bits
2016-12-01 10:24 ` Sergei Shtylyov
@ 2016-12-01 13:13 ` Chris Brandt
0 siblings, 0 replies; 5+ messages in thread
From: Chris Brandt @ 2016-12-01 13:13 UTC (permalink / raw)
To: Sergei Shtylyov, David Miller
Cc: Simon Horman, Geert Uytterhoeven, netdev@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
On 12/1/2016, Sergei Shtylyov wrote:
> Hello!
>
> Please always CC me on the sh_eth/ravb driver patches as directed by
> scripts/get_maintainer.pl.
OK. I'm sorry.
> On 11/30/2016 11:01 PM, Chris Brandt wrote:
>
> > When streaming a lot of data and the RZ can't keep up, some status
> > bits will get set that are not being checked or cleared which cause
> > the following messages and the Ethernet driver to stop working. This
> > patch fixes that issue.
>
> Perhaps we should just clear the correspoding bits in EESIPR instead?
> They are not set for any other SoC...
That's a good point. If we don't plan on doing anything with those bits, they should not be causing interrupts.
I will try change and then re-test.
Chris
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-12-01 13:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-30 20:01 [PATCH] sh_eth: add missing checks for status bits Chris Brandt
2016-12-01 8:52 ` Simon Horman
2016-12-01 10:12 ` Sergei Shtylyov
2016-12-01 10:24 ` Sergei Shtylyov
2016-12-01 13:13 ` Chris Brandt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).