From: Stephen Hemminger <stephen@networkplumber.org>
To: Nogah Frankel <nogahf@mellanox.com>
Cc: netdev@vger.kernel.org, eladr@mellanox.com, yotamg@mellanox.com,
jiri@mellanox.com, idosch@mellanox.com, ogerlitz@mellanox.com
Subject: Re: [PATCH iproute2 2/3] ifstat: Add extended statistics to ifstat
Date: Thu, 1 Dec 2016 10:46:11 -0800 [thread overview]
Message-ID: <20161201104611.1e3a5b05@xeon-e3> (raw)
In-Reply-To: <1479996760-61271-3-git-send-email-nogahf@mellanox.com>
On Thu, 24 Nov 2016 16:12:39 +0200
Nogah Frankel <nogahf@mellanox.com> wrote:
> Add extended stats option for ifstat. It supports stats that are in the
> nesting level as the "normal" stats or one lower, as long as they are in
> the same struct type as the "normal" stats.
> Every extension is unaware of data from other extension and is being
> presented by itself.
> The extension can be called by its name or any shorten of it. If there is
> more then one matched, the first one will be picked.
>
> To get the extended stats the flag -x <stats type> is used.
>
> Signed-off-by: Nogah Frankel <nogahf@mellanox.com>
> Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Finally clearing up iproute2 patch backlog. This feature looks good,
but does not apply cleanly to current git master branch.
--- misc/ifstat.c
+++ misc/ifstat.c
@@ -733,7 +790,8 @@ static void usage(void)
" -s, --noupdate don\'t update history\n"
" -t, --interval=SECS report average over the last SECS\n"
" -V, --version output version information\n"
-" -z, --zeros show entries with zero activity\n");
+" -z, --zeros show entries with zero activity\n"
+" -x, --extended=TYPE show extended stats of TYPE\n");
exit(-1);
}
Please rebase your patches and resubmit.
next prev parent reply other threads:[~2016-12-01 18:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 14:12 [PATCH iproute2 0/3] update ifstat for new stats Nogah Frankel
2016-11-24 14:12 ` [PATCH iproute2 1/3] ifstat: Change interface to get stats Nogah Frankel
2016-11-24 14:12 ` [PATCH iproute2 2/3] ifstat: Add extended statistics to ifstat Nogah Frankel
2016-12-01 18:46 ` Stephen Hemminger [this message]
2016-11-24 14:12 ` [PATCH iproute2 3/3] ifstat: Add "sw only" " Nogah Frankel
2016-11-27 18:00 ` [PATCH iproute2 0/3] update ifstat for new stats Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161201104611.1e3a5b05@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=eladr@mellanox.com \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nogahf@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).