netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: LinoSanfilippo@gmx.de
Cc: vbridger@opensource.altera.com, nios2-dev@lists.rocketboards.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] net: ethernet: altera: TSE: do not use tx queue lock in tx completion handler
Date: Fri, 02 Dec 2016 12:11:54 -0500 (EST)	[thread overview]
Message-ID: <20161202.121154.2111120437823188386.davem@davemloft.net> (raw)
In-Reply-To: <1480546112-3099-2-git-send-email-LinoSanfilippo@gmx.de>

From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Date: Wed, 30 Nov 2016 23:48:32 +0100

> The driver already uses its private lock for synchronization between xmit
> and xmit completion handler making the additional use of the xmit_lock
> unnecessary.
> Furthermore the driver does not set NETIF_F_LLTX resulting in xmit to be
> called with the xmit_lock held and then taking the private lock while xmit
> completion handler does the reverse, first take the private lock, then the
> xmit_lock.
> Fix these issues by not taking the xmit_lock in the tx completion handler.
> 
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>

Yeah that could be a nasty deadlock, in fact.

Applied, thanks.

  reply	other threads:[~2016-12-02 17:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-30 22:48 [PATCH 1/2] net: ethernet: altera: TSE: Remove unneeded dma sync for tx buffers Lino Sanfilippo
2016-11-30 22:48 ` [PATCH 2/2] net: ethernet: altera: TSE: do not use tx queue lock in tx completion handler Lino Sanfilippo
2016-12-02 17:11   ` David Miller [this message]
2016-12-02 17:11 ` [PATCH 1/2] net: ethernet: altera: TSE: Remove unneeded dma sync for tx buffers David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161202.121154.2111120437823188386.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=LinoSanfilippo@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nios2-dev@lists.rocketboards.org \
    --cc=vbridger@opensource.altera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).