From: Stephen Hemminger <stephen@networkplumber.org>
To: Roman Mashak <mrv@mojatatu.com>
Cc: netdev@vger.kernel.org, sathya.perla@broadcom.com
Subject: Re: [PATCH iproute2 1/1] tc: updated man page to reflect handle-id use in filter GET command.
Date: Fri, 2 Dec 2016 14:06:22 -0800 [thread overview]
Message-ID: <20161202140622.5ecad2d6@xeon-e3> (raw)
In-Reply-To: <1480623644-27533-1-git-send-email-mrv@mojatatu.com>
On Thu, 1 Dec 2016 15:20:44 -0500
Roman Mashak <mrv@mojatatu.com> wrote:
> Signed-off-by: Roman Mashak <mrv@mojatatu.com>
> ---
> man/man8/tc.8 | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/man/man8/tc.8 b/man/man8/tc.8
> index 8a47a2b..d957ffa 100644
> --- a/man/man8/tc.8
> +++ b/man/man8/tc.8
> @@ -32,7 +32,9 @@ class-id ] qdisc
> DEV
> .B [ parent
> qdisc-id
> -.B | root ] protocol
> +.B | root ] [ handle
> +handle-id ]
> +.B protocol
> protocol
> .B prio
> priority filtertype
> @@ -577,7 +579,7 @@ it is created.
>
> .TP
> get
> -Displays a single filter given the interface, parent ID, priority, protocol and handle ID.
> +Displays a single filter given the interface, qdisc-id, priority, protocol and handle-id.
>
> .TP
> show
The proper syntax for man page usage section is to put keywords in bold and any value
that is variable in italic.
I know this whole man page doesn't do this correctly. But that doesn't mean that new
additions should continue with the mistake.
Please revise and resubmit. Extra bonus points for fixing the other bits.
next prev parent reply other threads:[~2016-12-02 22:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 20:20 [PATCH iproute2 1/1] tc: updated man page to reflect handle-id use in filter GET command Roman Mashak
2016-12-02 22:06 ` Stephen Hemminger [this message]
2016-12-05 11:07 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161202140622.5ecad2d6@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).