From: Stephen Hemminger <stephen@networkplumber.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Isaac Boukris <iboukris@gmail.com>,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iproute2: ss: escape all null bytes in abstract unix domain socket
Date: Fri, 2 Dec 2016 15:18:10 -0800 [thread overview]
Message-ID: <20161202151810.4fab9504@xeon-e3> (raw)
In-Reply-To: <1480705196.18162.381.camel@edumazet-glaptop3.roam.corp.google.com>
On Fri, 02 Dec 2016 10:59:56 -0800
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Sat, 2016-11-12 at 10:17 +0300, Stephen Hemminger wrote:
> > On Sat, 29 Oct 2016 22:20:19 +0300
> > Isaac Boukris <iboukris@gmail.com> wrote:
> >
> > > Abstract unix domain socket may embed null characters,
> > > these should be translated to '@' when printed by ss the
> > > same way the null prefix is currently being translated.
> > >
> > > Signed-off-by: Isaac Boukris <iboukris@gmail.com>
> >
> > Applied
>
> Probably not a good idea to have :
>
> for (int i = 0; i < len; i++)
> if (name[i] == '\0')
> name[i] = '@';
>
> ss.c: In function 'unix_show_sock':
> ss.c:3128:4: error: 'for' loop initial declarations are only allowed in C99 mode
> ss.c:3128:4: note: use option -std=c99 or -std=gnu99 to compile your code
> make[1]: *** [ss.o] Error 1
>
>
>
Thanks, fixed by patch from Simon
next prev parent reply other threads:[~2016-12-02 23:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 19:20 [PATCH] iproute2: ss: escape all null bytes in abstract unix domain socket Isaac Boukris
2016-10-29 19:20 ` [PATCH] unix: " Isaac Boukris
2016-10-31 19:31 ` David Miller
2016-11-01 0:56 ` Isaac Boukris
2016-11-12 7:17 ` [PATCH] iproute2: ss: " Stephen Hemminger
2016-12-02 18:59 ` Eric Dumazet
2016-12-02 23:18 ` Stephen Hemminger [this message]
2016-12-02 23:24 ` Eric Dumazet
2016-12-05 5:38 ` Isaac Boukris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161202151810.4fab9504@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=iboukris@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).