Re: [PATCH/RFC iproute2/net-next 0/3] tc: flower: Support matching on ICMP

Simon Horman
2016-12-02T17:52:45Z

On Fri, Dec 02, 2016 at 06:10:20PM +0100, Jiri Pirko wrote:
> Fri, Dec 02, 2016 at 10:59:42AM CET, simon.horman@netronome.com wrote:
> >Add support for matching on ICMP type and code to flower. This is modeled
> >on existing support for matching on L4 ports.
> >
> >The second patch provided a minor cleanup which is in keeping with
> >they style used in the last patch.
> >
> >This is marked as an RFC to match the same designation given to the
> >corresponding kernel patches.
>
> Looks nice, I only have those 2 enum nitpicks.

Thanks, I'll fix those and repost.